Skip to content

RFC: sandbox: use created/stopped instead of infra container for readiness #9188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

RFC: sandbox: use created/stopped instead of infra container for readiness #9188

merged 1 commit into from
May 20, 2025

Conversation

haircommander
Copy link
Member

As we hit cases of deadlock when a sandbox is stuck stopping

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix a potential deadlock when an infra container is taking a long time to exit and the sandbox's readiness is blocked on the infra container's opLock

@haircommander haircommander requested a review from mrunalp as a code owner May 8, 2025 21:06
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 8, 2025
@openshift-ci openshift-ci bot requested review from klihub and QiWang19 May 8, 2025 21:06
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label May 8, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2025
@codecov Codecov
Copy link

codecov bot commented May 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.22222% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.75%. Comparing base (1598501) to head (290edee).
Report is 39 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #9188       +/-   ##
===========================================
+ Coverage   47.04%   66.75%   +19.70%     
===========================================
  Files         161      198       +37     
  Lines       23689    27164     +3475     
===========================================
+ Hits        11144    18132     +6988     
+ Misses      11445     7545     -3900     
- Partials     1100     1487      +387
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@haircommander
Copy link
Member Author

/test periodics-images

@haircommander
Copy link
Member Author

/test ci-rhel-critest

@haircommander
Copy link
Member Author

/retest

bitoku
bitoku reviewed May 9, 2025
View reviewed changes
@haircommander haircommander force-pushed the living-readines branch 3 times, most recently from 3a835ad to d7b0589 Compare May 9, 2025 20:00
@haircommander
Copy link
Member Author

/retest

@bitoku
Copy link
Contributor

bitoku commented May 15, 2025

/hold
@haircommander integration tests timed out somehow.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2025
@haircommander haircommander force-pushed the living-readines branch 2 times, most recently from 678c142 to e14a7d1 Compare May 16, 2025 17:44
@haircommander
Copy link
Member Author

/unhold

fixed!

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2025
@haircommander
sandbox: use created/stopped instead of infra container for readiness
290edee 
As we hit cases of deadlock when a sandbox is stuck stopping

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 19, 2025

@haircommander: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-e2e-evented-pleg 290edee link false /test ci-e2e-evented-pleg

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bitoku
Copy link
Contributor

bitoku commented May 20, 2025

/lgtm
thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2025
@bitoku
Copy link
Contributor

bitoku commented May 20, 2025

/skip

@openshift-merge-bot openshift-merge-bot bot merged commit e738af1 into cri-o:main May 20, 2025
85 of 89 checks passed
@haircommander
Copy link
Member Author

/cherry-pick release-1.33

@openshift-cherrypick-robot
Copy link

@haircommander: new pull request created: #9214

In response to this:

/cherry-pick release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 21, 2025
Merged
@github-actions github-actions bot mentioned this pull request Sep 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitoku bitoku bitoku left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@QiWang19 QiWang19 Awaiting requested review from QiWang19

Assignees

@bitoku bitoku

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haircommander @bitoku @openshift-cherrypick-robot