Skip to content

server/nri: allow NRI plugins to inject CDI devices. #9128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2025
Merged

server/nri: allow NRI plugins to inject CDI devices. #9128

merged 1 commit into from
Jul 14, 2025

Conversation

klihub
Copy link
Contributor

@klihub klihub commented Apr 11, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

A missing option prevented us from honoring CDI device injection by NRI plugins during container adjustment.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixed a bug which caused CDI injection by NRI plugins to not being honored. NRI plugins are now able to inject CDI devices into containers.

@klihub klihub requested a review from mrunalp as a code owner April 11, 2025 15:27
@openshift-ci openshift-ci bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 11, 2025
@openshift-ci openshift-ci bot requested review from hasan4791 and littlejawa April 11, 2025 15:27
@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 11, 2025
@klihub
Copy link
Contributor Author

klihub commented Apr 11, 2025

/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klihub, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2025
@haircommander
Copy link
Member

/override ci/prow/ci-e2e-evented-pleg

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 22, 2025

@haircommander: Overrode contexts on behalf of haircommander: ci/prow/ci-e2e-evented-pleg

In response to this:

/override ci/prow/ci-e2e-evented-pleg

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bitoku
Copy link
Contributor

bitoku commented Apr 25, 2025

/retest

@bitoku
Copy link
Contributor

bitoku commented Apr 25, 2025

/retest-required

@klihub klihub force-pushed the fixes/nri-cdi-device-injection branch from c1f3389 to 8458162 Compare April 28, 2025 06:15
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 66.84%. Comparing base (9cdf516) to head (75247c9).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9128      +/-   ##
==========================================
- Coverage   66.91%   66.84%   -0.07%     
==========================================
  Files         199      199              
  Lines       27456    27469      +13     
==========================================
- Hits        18372    18363       -9     
- Misses       7566     7585      +19     
- Partials     1518     1521       +3
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions GitHub Actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 29, 2025
@klihub klihub force-pushed the fixes/nri-cdi-device-injection branch from 8458162 to c4a1171 Compare June 30, 2025 13:10
@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 1, 2025
@bitoku
Copy link
Contributor

bitoku commented Jul 11, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2025
@klihub
server/nri: allow NRI plugins to inject CDI devices.
75247c9 
Add missing option to handle CDI device injection by NRI
plugins.

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub klihub force-pushed the fixes/nri-cdi-device-injection branch from c4a1171 to 75247c9 Compare July 14, 2025 07:41
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2025
@saschagrunert
Copy link
Member

/override ci/prow/ci-e2e-evented-pleg

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 14, 2025

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-e2e-evented-pleg

In response to this:

/override ci/prow/ci-e2e-evented-pleg

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@saschagrunert
Copy link
Member

/retest

@klihub
Copy link
Contributor Author

klihub commented Jul 14, 2025

/cc @haircommander

@openshift-ci openshift-ci bot requested a review from haircommander July 14, 2025 11:12
@haircommander
Copy link
Member

/override ci/prow/e2e-aws-ovn
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 14, 2025

@haircommander: Overrode contexts on behalf of haircommander: ci/prow/e2e-aws-ovn

In response to this:

/override ci/prow/e2e-aws-ovn
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 92381ff into cri-o:main Jul 14, 2025
73 of 75 checks passed
@klihub klihub deleted the fixes/nri-cdi-device-injection branch July 15, 2025 12:51
@github-actions github-actions bot mentioned this pull request Sep 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@hasan4791 hasan4791 Awaiting requested review from hasan4791

@littlejawa littlejawa Awaiting requested review from littlejawa

@haircommander haircommander Awaiting requested review from haircommander

Assignees

@saschagrunert saschagrunert

@bitoku bitoku

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@klihub @haircommander @bitoku @saschagrunert