Skip to content

Bump go version to 1.24.3 #9272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 23, 2025
Merged

Bump go version to 1.24.3 #9272

merged 3 commits into from
Jun 23, 2025

Conversation

bitoku
Copy link
Contributor

@bitoku bitoku commented Jun 21, 2025 •
edited by sohankunkerkar
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixes #9181

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixed segmentation fault when trying to create a lot of pods at a time.

@bitoku
Bump go version to 1.24.3
4450e69 
Signed-off-by: Ayato Tokubi <atokubi@redhat.com>
@bitoku bitoku requested a review from mrunalp as a code owner June 21, 2025 18:06
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 21, 2025
@openshift-ci openshift-ci bot requested review from littlejawa and QiWang19 June 21, 2025 18:06
@codecov Codecov
Copy link

codecov bot commented Jun 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.15%. Comparing base (5e36958) to head (ba6a884).
Report is 10 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9272      +/-   ##
==========================================
- Coverage   66.85%   66.15%   -0.71%     
==========================================
  Files         198      198              
  Lines       27176    27176              
==========================================
- Hits        18169    17977     -192     
- Misses       7505     7691     +186     
- Partials     1502     1508       +6
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

kannon92
kannon92 reviewed Jun 21, 2025
View reviewed changes
Copy link
Contributor

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2025
@sohankunkerkar
Copy link
Member

Can you fix the nix builds as well?
I think you need pin the golang version there.

@bitoku
update nixpkgs
7cf556a 
Signed-off-by: Ayato Tokubi <atokubi@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2025
@bitoku
fix prettier
ba6a884 
Signed-off-by: Ayato Tokubi <atokubi@redhat.com>
@rphillips
Copy link
Contributor

/retest

@rphillips
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bitoku, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2025
@sohankunkerkar
Copy link
Member

/override ci/prow/ci-e2e-evented-pleg

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 23, 2025

@sohankunkerkar: Overrode contexts on behalf of sohankunkerkar: ci/prow/ci-e2e-evented-pleg

In response to this:

/override ci/prow/ci-e2e-evented-pleg

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sohankunkerkar
Copy link
Member

Last two runs were green and the failure doesn't seem related to this change. Overriding this test for now.

/override ci/prow/e2e-aws-ovn

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 23, 2025

@sohankunkerkar: Overrode contexts on behalf of sohankunkerkar: ci/prow/e2e-aws-ovn

In response to this:

Last two runs were green and the failure doesn't seem related to this change. Overriding this test for now.

/override ci/prow/e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 5655aea into cri-o:main Jun 23, 2025
92 of 108 checks passed
@bitoku
Copy link
Contributor Author

bitoku commented Jul 29, 2025

/cherry-pick 1.33

@openshift-cherrypick-robot
Copy link

@bitoku: cannot checkout 1.33: error checking out "1.33": exit status 1 error: pathspec '1.33' did not match any file(s) known to git

In response to this:

/cherry-pick 1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bitoku
Copy link
Contributor Author

bitoku commented Jul 29, 2025

/cherry-pick release-1.33

@openshift-cherrypick-robot
Copy link

@bitoku: new pull request created: #9368

In response to this:

/cherry-pick release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 29, 2025
Merged
@github-actions github-actions bot mentioned this pull request Sep 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohankunkerkar sohankunkerkar sohankunkerkar approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@littlejawa littlejawa Awaiting requested review from littlejawa

@QiWang19 QiWang19 Awaiting requested review from QiWang19

+1 more reviewer

@kannon92 kannon92 kannon92 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@rphillips rphillips

@kannon92 kannon92

@sohankunkerkar sohankunkerkar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segmentation Fault when deploying many pods at a time
5 participants
@bitoku @sohankunkerkar @rphillips @openshift-cherrypick-robot @kannon92