Deprecate insecure_registries config #9278
Conversation
2ff4837 to
f9fbb9d
Compare
| if len(serverConfig.InsecureRegistries) > 0 { | ||
| log.Warnf(ctx, "Insecure registries option is deprecated and will be no effect") | ||
| } | ||
| serverConfig.InsecureRegistries = append(serverConfig.InsecureRegistries, "127.0.0.0/8") |
There was a problem hiding this comment.
This 127.0.0.0/8 will be removed when we completely remove the option.
Do we want to have a new option like insecureLoopback and deprecate it separately to reduce the impact as much as possible? or is it too much?
There was a problem hiding this comment.
I can't recall who requires this, but I tend to say no, let's deprecate without having a replacement for this for now.
3e39a3e to
622daa9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9278 +/- ##
==========================================
+ Coverage 66.52% 66.97% +0.45%
==========================================
Files 198 198
Lines 27159 27198 +39
==========================================
+ Hits 18067 18217 +150
+ Misses 7606 7482 -124
- Partials 1486 1499 +13 🚀 New features to boost your workflow:
|
|
@cri-o/cri-o-maintainers PTAL |
Signed-off-by: Ayato Tokubi <atokubi@redhat.com>
622daa9 to
9d0dd61
Compare
|
@bitoku: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/skip |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bitoku, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind deprecation
What this PR does / why we need it:
This PR deprecates insecure-registries, which causes unnecessary DNS resolution.
Which issue(s) this PR fixes:
part of #9225
Special notes for your reviewer:
Does this PR introduce a user-facing change?