Add conmon-rs streaming server support for Exec and Attach
#9289
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c46b4fa to
61ab3f7
Compare
Exec and AttachExec and Attach
5aeb08a to
9913428
Compare
|
I wonder if there's a way we can plumb the knowledge of websocket v spdy into the request so we can toggle behavior, but that's longer term (or maybe we just move away from spdy...) |
9913428 to
0bc89ae
Compare
I was thinking about the same. Considering that the transition from SPDY to WS is already ongoing in kubernetes/enhancements#4006, I'd say we don't keep too much backwards compatibility (we also don't have websocket support right now). The conversation could be a good topic for the v1.35 cycle. |
0bc89ae to
dfcc3b3
Compare
Exec and AttachExec and Attach
Exec and AttachExec and Attach
7cb4a50 to
c9e97c4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9289 +/- ##
==========================================
+ Coverage 66.92% 66.99% +0.07%
==========================================
Files 198 198
Lines 27306 27406 +100
==========================================
+ Hits 18274 18362 +88
- Misses 7525 7530 +5
- Partials 1507 1514 +7 🚀 New features to boost your workflow:
|
Exec and AttachExec and Attach
Exec and AttachExec and Attach
|
/retest |
1 similar comment
|
/retest |
|
@cri-o/cri-o-maintainers PTAL |
|
/override ci/prow/ci-e2e-evented-pleg |
|
@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-e2e-evented-pleg In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
88d7337 to
d093e92
Compare
|
/override ci/prow/ci-e2e-evented-pleg |
|
@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-e2e-evented-pleg In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
baf6e4e to
730d7aa
Compare
Exec and AttachExec and Attach
730d7aa to
93a4c42
Compare
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
93a4c42 to
16a08eb
Compare
Exec and AttachExec and Attach
|
/retest |
|
/override ci/prow/ci-e2e-evented-pleg |
|
@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-e2e-evented-pleg In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add support for websocket exec and attach using conmon-rs. This means that those sessions will survive a CRI-O restart. Drawback is that we cannot know if spdy or a websocket connection is being used on setup. Therefore we cannot support spdy through conmon-rs anymore. The whole feature is gated through the
stream_websocketsruntime handler configuration.Which issue(s) this PR fixes:
Refers to #7826, kubernetes/enhancements#4006
Special notes for your reviewer:
Requires #9290
Does this PR introduce a user-facing change?