-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[1.31][4.18] OCPBUGS-59416: HighPerformanceHooks: Fix IRQ SMP affinity race conditions #9351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-1.31
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: andreaskaris The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @andreaskaris. Thanks for your PR. I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@andreaskaris: This pull request references Jira Issue OCPBUGS-59416, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
To do: Have to fix conflict in unit test due to missing:
|
94ea23f
to
6c297b9
Compare
@andreaskaris: This pull request references Jira Issue OCPBUGS-59416, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/ok-to-test |
/hold I found another issue with race conditions and other pieces must be fixed upstream before merging this |
6697640
to
f8bd50a
Compare
A friendly reminder that this PR had no activity for 30 days. |
Cherry-pick of: - Merge pull request cri-o#9228 from andreaskaris/issue9227 The original 6 commits merged but were not squashed together, therefore doing this here on the downstream cherry-pick. (cherry picked from commit 3dce7d8) (cherry picked from commit 7cddfd4) (cherry picked from commit 5c39a2e) Conflicts: internal/runtimehandlerhooks/high_performance_hooks_test.go Needed to convert sandbox.NewBuilder to sandbox.New due to missing 409a15. server/sandbox_stop_freebsd.go Needed to make manual change due to downstream call to GetRuntimeHandlerHooks in FreeBSD implementation. Signed-off-by: Andreas Karis <ak.karis@gmail.com> Reported-at: https://issues.redhat.com/browse/OCPBUGS-59416
A prior patch addressing race conditions in this code section was incomplete as it used 2 different locks for irqbalance and irq SMP affinity files. This still allowed for a race condition wrt irqbalance configuration. This fix addresses this issue by using a single lock and by making the entire change atomic. Signed-off-by: Andreas Karis <ak.karis@gmail.com> (cherry picked from commit 1283afc) Conflicts: internal/runtimehandlerhooks/high_performance_hooks_linux.go Not applying cleanly to setIRQLoadBalancing, accepting all of new change (cherry picked from commit ff418a1)
Add unit tests for irq smp affinity settings. In order to do so, add service and command manager structures that can be mocked. Signed-off-by: Andreas Karis <ak.karis@gmail.com> (cherry picked from commit 06c8437) Conflicts: internal/runtimehandlerhooks/high_performance_hooks_linux.go applying to RestoreIrqBalanceConfig, accepting incoming changes (cherry picked from commit 20da163)
Having IRQ balancing logic inside the PreStop hook can cause issues with ordering (possibility to hit sequence container add, replacement container add, container stop). Moving the same logic into PostStop will guarantee correct ordering. Signed-off-by: Andreas Karis <ak.karis@gmail.com> (cherry picked from commit 03ec73d) Conflicts: internal/runtimehandlerhooks/high_performance_hooks_linux.go applying to PostStop, accepted all incoming changes (cleanly) (cherry picked from commit 211098d)
f8bd50a
to
f5dceec
Compare
@andreaskaris: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
cherry-pick of #9350
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
The same as for the change to
main
, I ran a smoke test for sanity checking:I ran my smoke test on a VM with 14 CPUs where I first installed the entire stack with kubeadm.
Dependencies:
/etc/crio/crio.conf.d/99-runtimes.conf
I then stopped the crio service, started the compiled crio in foreground
make binaries && bin/crio
, and ran this smoke test:smoke.sh
pod.yaml
Does this PR introduce a user-facing change?