Skip to content

Implement container_processes metric #9366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2025
Merged

Implement container_processes metric #9366

merged 1 commit into from
Aug 6, 2025
+69 −2

Conversation

gavinkflam
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

CRI-O is not reporting container processes metric.

Which issue(s) this PR fixes:

Part of #9125

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added container processes (`container_processes`) metric.

@gavinkflam gavinkflam requested a review from mrunalp as a code owner July 29, 2025 03:59
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 29, 2025
@openshift-ci openshift-ci bot requested review from bitoku and QiWang19 July 29, 2025 03:59
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 29, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 29, 2025

Hi @gavinkflam. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Jul 29, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.32%. Comparing base (2687346) to head (2ed6cca).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9366      +/-   ##
==========================================
+ Coverage   66.79%   67.32%   +0.53%     
==========================================
  Files         200      201       +1     
  Lines       27628    27698      +70     
==========================================
+ Hits        18454    18648     +194     
+ Misses       7652     7505     -147     
- Partials     1522     1545      +23
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gavinkflam
Copy link
Contributor Author

/cc @bitoku @sohankunkerkar @saschagrunert

if you get a chance, please review the changes and provide an ok-to-test

@saschagrunert
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 29, 2025
@sreeram-venkitesh sreeram-venkitesh mentioned this pull request Jul 29, 2025
Open
@gavinkflam gavinkflam force-pushed the 9125-container-processes-metric branch from 854fe2c to 70b4c5d Compare July 30, 2025 02:56
bitoku
bitoku approved these changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@bitoku bitoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I left one comment, but it's not blocking.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2025
@bitoku
Copy link
Contributor

bitoku commented Jul 30, 2025

@cri-o/cri-o-maintainers PTAL

@gavinkflam gavinkflam force-pushed the 9125-container-processes-metric branch from 70b4c5d to fe12244 Compare July 31, 2025 03:55
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2025
@gavinkflam
Implement container_processes metric
2ed6cca 
Signed-off-by: Gavin Lam <gavin.oss@tutamail.com>
@gavinkflam gavinkflam force-pushed the 9125-container-processes-metric branch from fe12244 to 2ed6cca Compare July 31, 2025 04:02
@gavinkflam
Copy link
Contributor Author

@bitoku I've just pushed an update to address your comment. Please take another look.

@gavinkflam gavinkflam requested a review from bitoku July 31, 2025 04:04
@bitoku
Copy link
Contributor

bitoku commented Jul 31, 2025

/lgtm
@cri-o/cri-o-maintainers PTAL

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2025
sohankunkerkar
sohankunkerkar approved these changes Aug 5, 2025
View reviewed changes
Copy link
Member

@sohankunkerkar sohankunkerkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bitoku, gavinkflam, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 06e7803 into cri-o:main Aug 6, 2025
74 checks passed
@gavinkflam gavinkflam deleted the 9125-container-processes-metric branch August 6, 2025 00:34
@github-actions github-actions bot mentioned this pull request Sep 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohankunkerkar sohankunkerkar sohankunkerkar approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@QiWang19 QiWang19 Awaiting requested review from QiWang19

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

@bitoku bitoku Awaiting requested review from bitoku

Assignees

@bitoku bitoku

@sohankunkerkar sohankunkerkar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gavinkflam @saschagrunert @bitoku @sohankunkerkar