Skip to content

[release-1.33] OCPNODE-2864: Set ExecCPUAffinity #9370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-1.33
Choose a base branch
from
Open

[release-1.33] OCPNODE-2864: Set ExecCPUAffinity #9370

wants to merge 1 commit into from

Conversation

bitoku
Copy link
Contributor

@bitoku bitoku commented Jul 31, 2025 •
edited
Loading

(cherry picked from commit 4dd7fb9)

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR backports a feature of ExecCPUAffinity #9286
About why we backport it. https://issues.redhat.com/browse/OCPNODE-2864?focusedId=27697751&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-27697751

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added `exec_cpu_affinity` type which can specify cpu where exec command runs.

@bitoku
Set ExecCPUAffinity
6fd926d 
Signed-off-by: Ayato Tokubi <atokubi@redhat.com>

(cherry picked from commit 4dd7fb9)
Signed-off-by: Ayato Tokubi <atokubi@redhat.com>
@bitoku bitoku requested a review from mrunalp as a code owner July 31, 2025 10:50
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 31, 2025
@openshift-ci-robot
Copy link

@bitoku: This pull request references OCPNODE-2864 which is a valid jira issue.

In response to this:

(cherry picked from commit 4dd7fb9)

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR backports a feature of ExecCPUAffinity, which we don't usually do.
Backporting #9286

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added `exec_cpu_affinity` type which can specify cpu where exec command runs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 31, 2025
@openshift-ci openshift-ci bot requested a review from klihub July 31, 2025 10:50
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 31, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bitoku
Once this PR has been reviewed and has the lgtm label, please assign saschagrunert for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested a review from littlejawa July 31, 2025 10:50
@codecov Codecov
Copy link

codecov bot commented Jul 31, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 64.28571% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.02%. Comparing base (ca9816c) to head (6fd926d).
⚠️ Report is 12 commits behind head on release-1.33.

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.33    #9370      +/-   ##
================================================
+ Coverage         47.97%   48.02%   +0.05%     
================================================
  Files               163      163              
  Lines             24117    24172      +55     
================================================
+ Hits              11570    11609      +39     
- Misses            11405    11418      +13     
- Partials           1142     1145       +3
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bitoku
Copy link
Contributor Author

bitoku commented Jul 31, 2025

/retest

2 similar comments
@bitoku
Copy link
Contributor Author

bitoku commented Aug 1, 2025

/retest

@bitoku
Copy link
Contributor Author

bitoku commented Aug 1, 2025

/retest

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 1, 2025

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@littlejawa littlejawa Awaiting requested review from littlejawa

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bitoku @openshift-ci-robot