Skip to content

Update install.md - Add Dep for Ubuntu 24 #9379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update install.md - Add Dep for Ubuntu 24 #9379

wants to merge 1 commit into from
+1 −0

Conversation

thegreatfatzby
Copy link

I added "golang-go" explicitly to the apt install Ubuntu 24 section, it might be something odd/interesting on my end but when I ran the install list as currently given I got "go not found", which explicitly installing golang-go fixed, so I thought I'd add it here.

To show the steps I took with editing, I ran:

root@ubuntu-linux-2404:~# apt update -qq && apt install -y \
  libbtrfs-dev \
  golang-github-containers-common \
  git \
  libassuan-dev \
  libglib2.0-dev \
  libc6-dev \
  libgpgme-dev \
  libgpg-error-dev \
  libseccomp-dev \
  libsystemd-dev \
  libselinux1-dev \
  pkg-config \
  go-md2man \
  crun \
  libudev-dev \
  software-properties-common \
  gcc \
  make
7 packages can be upgraded. Run 'apt list --upgradable' to see them.
etc

Clone cri-o, cd in, then

root@ubuntu-linux-2404:~/cri-o# make
hack/libsubid_tag.sh: line 2: go: command not found
go build -trimpath  -ldflags '-s -w -X github.com/cri-o/cri-o/internal/version.buildDate='2025-08-02T18:13:27Z' ' -tags "containers_image_ostree_stub     seccomp selinux "  -o bin/crio ./cmd/crio
/bin/sh: 1: go: not found
make: *** [Makefile:213: bin/crio] Error 127

Then:

root@ubuntu-linux-2404:~/cri-o# apt install golang-go
Reading package lists... Done
Building dependency tree... Done
etc

Then make succeeds:

root@ubuntu-linux-2404:~/cri-o# make
go: downloading go1.24.3 (linux/arm64)
etc
root@ubuntu-linux-2404:~/cri-o# echo $?
0

What type of PR is this?

Documentation

What this PR does / why we need it:

Possibly make someone else's install path on Ubuntu 24 easier.

Which issue(s) this PR fixes:

None, didn't open an issue.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

None

@thegreatfatzby
Update install.md - Add Dep for Ubuntu 24
8aeda96 
I added "golang-go" explicitly to the apt install Ubuntu 24 section, it might be something odd/interesting on my end but when I ran the install list as currently given I got "go not found", which explicitly installing golang-go fixed, so I thought I'd add it here.



Signed-off-by: Isaac Foster <isaac.z.foster@gmail.com>
@thegreatfatzby thegreatfatzby requested a review from mrunalp as a code owner August 2, 2025 18:34
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 2, 2025
@openshift-ci openshift-ci bot requested review from bitoku and hasan4791 August 2, 2025 18:34
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 2, 2025

Hi @thegreatfatzby. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 2, 2025
saschagrunert
saschagrunert approved these changes Aug 4, 2025
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 4, 2025
@codecov Codecov
Copy link

codecov bot commented Aug 4, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.91%. Comparing base (86dd5c7) to head (8aeda96).
⚠️ Report is 128 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9379      +/-   ##
==========================================
- Coverage   67.25%   65.91%   -1.35%     
==========================================
  Files         200      200              
  Lines       27680    27680              
==========================================
- Hits        18616    18245     -371     
- Misses       7519     7868     +349     
- Partials     1545     1567      +22
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@saschagrunert
Copy link
Member

/ok-to-test

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, thegreatfatzby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bitoku
Copy link
Contributor

bitoku commented Aug 5, 2025

/retest-required

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2025

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 5, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 6, 2025

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 6, 2025
@bitoku
Copy link
Contributor

bitoku commented Oct 8, 2025

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 8, 2025

@thegreatfatzby: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-fedora-integration 8aeda96 link unknown /test ci-fedora-integration

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@bitoku bitoku Awaiting requested review from bitoku

@hasan4791 hasan4791 Awaiting requested review from hasan4791

Assignees

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thegreatfatzby @saschagrunert @bitoku