[release-1.32] fix GitHub action CI test setup, failing tests. #9318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.32 #9318 +/- ##
=============================================
Coverage 47.11% 47.11%
=============================================
Files 154 154
Lines 22221 22221
=============================================
Hits 10469 10469
Misses 10680 10680
Partials 1072 1072 🚀 New features to boost your workflow:
|
1418a06 to
3085ad3
Compare
|
/cc @bitoku |
|
/cc @saschagrunert |
|
/retest |
|
@cri-o/cri-o-maintainers PTAL |
It's a long story (see [1], [2], [3], [4]) but both runc and crun is changing the formula to convert cgroup v1 CPU shares to cgroup v2 CPU weight, and it causes a failure in "ctr update resources" test, because it relies on the old conversion formula. Let's modify it so it works either the old or the new conversion. (Ultimately, with cgroup v2 we should switch to setting unified.cpu.weight directly). [1]: kubernetes/kubernetes#131216 [2]: opencontainers/runc#4772 [3]: opencontainers/cgroups#20 [4]: containers/crun#1767 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Fixup for failing test after 438d528. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
3085ad3 to
01b68d6
Compare
|
@klihub do you mind also fixing the prettier CI? |
@saschagrunert In this same PR ? I think we have #9346 open for that separately... |
|
But I can fold it to this one, too. |
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Cherry-picked the prettier-fixing commit here... |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: klihub, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
03afa42
into
cri-o:release-1.32
48 of 49 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind ci
What this PR does / why we need it:
Fix GitHub action CI test setup (missing br_netfilter).
Cherry-pick #9271 for failing container update test in
test/ctr.bats.Fix failing test due to a mismatching test pattern altered in 438d528.
Fix markdown to make docs pass the prettier-verification in CI.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?