Pre-check streaming websockets on config validation #9324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d53ee48 to
20f7796
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9324 +/- ##
==========================================
- Coverage 66.91% 66.88% -0.04%
==========================================
Files 198 198
Lines 27406 27426 +20
==========================================
+ Hits 18340 18345 +5
- Misses 7551 7563 +12
- Partials 1515 1518 +3 🚀 New features to boost your workflow:
|
This change disallows streaming websockets for other runtimes than "pod". If conmon-rs version API is available, then it will also print the version. If the version API is not available, then the config validation implicitly assumes that conmon-rs < 0.7.0 is being used, which does not support the streaming server at all. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
20f7796 to
898a9d0
Compare
|
@cri-o/cri-o-maintainers PTAL |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Use the new conmon-rs API to pre-validate the version requirements.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?