Skip to content

Do nothing when the conmon is already confirmed dead. #9333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2025
Merged

Do nothing when the conmon is already confirmed dead. #9333

merged 1 commit into from
Jul 16, 2025

Conversation

bitoku
Copy link
Contributor

@bitoku bitoku commented Jul 10, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

Don't log errors or emit metrics when cri-o already confirmed conmon is dead.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix the bug where it continues to emit a metric after it confirms the conmon is stopped once

@bitoku bitoku requested a review from mrunalp as a code owner July 10, 2025 17:08
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Jul 10, 2025
@openshift-ci openshift-ci bot requested review from klihub and littlejawa July 10, 2025 17:08
@openshift-ci openshift-ci bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jul 10, 2025
haircommander
haircommander reviewed Jul 10, 2025
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Jul 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.93%. Comparing base (c926682) to head (aaf7494).
Report is 11 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9333      +/-   ##
==========================================
- Coverage   66.95%   66.93%   -0.03%     
==========================================
  Files         198      199       +1     
  Lines       27426    27464      +38     
==========================================
+ Hits        18364    18383      +19     
- Misses       7545     7563      +18     
- Partials     1517     1518       +1
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bitoku bitoku force-pushed the fix-noisy-alert branch 3 times, most recently from ffbfb6f to 7b59e3c Compare July 11, 2025 10:02
@bitoku
Don't log errors or emit metrics when cri-o already confirmed conmon …
aaf7494 
…is dead.

Signed-off-by: Ayato Tokubi <atokubi@redhat.com>
@bitoku bitoku force-pushed the fix-noisy-alert branch from 7b59e3c to aaf7494 Compare July 11, 2025 12:12
@bitoku
Copy link
Contributor Author

bitoku commented Jul 11, 2025

/retest

3 similar comments
@bitoku
Copy link
Contributor Author

bitoku commented Jul 15, 2025

/retest

@bitoku
Copy link
Contributor Author

bitoku commented Jul 15, 2025

/retest

@bitoku
Copy link
Contributor Author

bitoku commented Jul 15, 2025

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 15, 2025 •
edited
Loading

@bitoku: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-e2e-evented-pleg aaf7494 link false /test ci-e2e-evented-pleg

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bitoku, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit da378e0 into cri-o:main Jul 16, 2025
73 of 75 checks passed
@github-actions github-actions bot mentioned this pull request Sep 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haircommander haircommander haircommander left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@littlejawa littlejawa Awaiting requested review from littlejawa

Assignees

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bitoku @saschagrunert @haircommander