Skip to content

Close runtime connection on watchdog call #9448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Close runtime connection on watchdog call #9448

wants to merge 1 commit into from

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

Closing the watchdog connection through the new API after use.

Which issue(s) this PR fixes:

Fixes #9360

Special notes for your reviewer:

Requires a vendored v1.35 version of k/k.

Does this PR introduce a user-facing change?

Fixed memory leak with CRI connection when using the systemd watchdog feature.

@openshift-ci openshift-ci bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 3, 2025
@saschagrunert saschagrunert added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 3, 2025
@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. labels Sep 3, 2025
@saschagrunert saschagrunert self-assigned this Sep 3, 2025
@openshift-ci openshift-ci bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 3, 2025
@openshift-ci openshift-ci bot requested review from klihub and QiWang19 September 3, 2025 07:16
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2025
@saschagrunert saschagrunert mentioned this pull request Sep 3, 2025
Open
@codecov Codecov
Copy link

codecov bot commented Sep 3, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 67.05%. Comparing base (85191e7) to head (51ba8b4).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9448      +/-   ##
==========================================
- Coverage   67.13%   67.05%   -0.08%     
==========================================
  Files         202      202              
  Lines       28140    28143       +3     
==========================================
- Hits        18891    18871      -20     
- Misses       7670     7693      +23     
  Partials     1579     1579
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 13, 2025
@saschagrunert
Close runtime connection on watchdog call
51ba8b4 
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 1, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 1, 2025 •
edited
Loading

@saschagrunert: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-cgroupv2-integration 51ba8b4 link true /test ci-cgroupv2-integration
ci/prow/ci-cgroupv2-e2e-crun 51ba8b4 link true /test ci-cgroupv2-e2e-crun
ci/prow/ci-rhel-critest 51ba8b4 link true /test ci-rhel-critest
ci/prow/ci-cgroupv2-e2e-features 51ba8b4 link true /test ci-cgroupv2-e2e-features
ci/prow/ci-fedora-kata 51ba8b4 link true /test ci-fedora-kata
ci/prow/ci-crun-e2e 51ba8b4 link true /test ci-crun-e2e
ci/prow/ci-fedora-integration 51ba8b4 link true /test ci-fedora-integration

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 4, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@QiWang19 QiWang19 Awaiting requested review from QiWang19

Assignees

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory leak with systemd watchdog
2 participants
@saschagrunert @openshift-merge-robot