Skip to content

Warn when CONTAINER_INCLUDED_POD_METRCIS (typo) is used. #9454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2025
Merged

Warn when CONTAINER_INCLUDED_POD_METRCIS (typo) is used. #9454

merged 1 commit into from
Sep 7, 2025

Conversation

bitoku
Copy link
Contributor

@bitoku bitoku commented Sep 5, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

The release note has already been added in #9299

What this PR does / why we need it:

Warn when CONTAINER_INCLUDED_POD_METRCIS (typo) is used.

Which issue(s) this PR fixes:

Fixes #9300

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@bitoku bitoku requested a review from mrunalp as a code owner September 5, 2025 13:10
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. kind/deprecation dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Sep 5, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 5, 2025

Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 5, 2025
@bitoku
Warn when CONTAINER_INCLUDED_POD_METRCIS (typo) is used.
1c4060d 
Signed-off-by: Ayato Tokubi <atokubi@redhat.com>
@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Sep 5, 2025
@bitoku bitoku added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/deprecation labels Sep 5, 2025
@codecov Codecov
Copy link

codecov bot commented Sep 5, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.02%. Comparing base (b004022) to head (1c4060d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9454      +/-   ##
==========================================
- Coverage   67.06%   67.02%   -0.04%     
==========================================
  Files         202      202              
  Lines       27945    27948       +3     
==========================================
- Hits        18740    18732       -8     
- Misses       7635     7643       +8     
- Partials     1570     1573       +3
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bitoku
Copy link
Contributor Author

bitoku commented Sep 5, 2025

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bitoku, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 8e6b182 into cri-o:main Sep 7, 2025
74 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@hasan4791 hasan4791 Awaiting requested review from hasan4791

@littlejawa littlejawa Awaiting requested review from littlejawa

Assignees

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warn when CONTAINER_INCLUDED_POD_METRCIS is used
2 participants
@bitoku @saschagrunert