Skip to content

Add crio.runtime.runtimes seccomp_profile to crio.conf.5 doc #9458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2025
Merged

Add crio.runtime.runtimes seccomp_profile to crio.conf.5 doc #9458

merged 1 commit into from
Sep 9, 2025

Conversation

gavinkflam
Copy link
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it:

I've added crio.runtime.runtimes seccomp_profile in #9424. This is to add the new configuration to the crio.conf.5 document.

Which issue(s) this PR fixes:

Part of #5715

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@gavinkflam
Add crio.runtime.runtimes seccomp_profile to crio.conf.5 doc
7a4365c 
Signed-off-by: Gavin Lam <gavin.oss@tutamail.com>
@gavinkflam gavinkflam requested a review from mrunalp as a code owner September 9, 2025 02:23
@openshift-ci openshift-ci bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 9, 2025
@openshift-ci openshift-ci bot requested review from hasan4791 and klihub September 9, 2025 02:24
@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/documentation Categorizes issue or PR as related to documentation. labels Sep 9, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 9, 2025

Hi @gavinkflam. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 9, 2025
@codecov Codecov
Copy link

codecov bot commented Sep 9, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.09%. Comparing base (aea52d6) to head (7a4365c).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9458      +/-   ##
==========================================
+ Coverage   67.07%   67.09%   +0.02%     
==========================================
  Files         202      202              
  Lines       27997    27997              
==========================================
+ Hits        18779    18785       +6     
+ Misses       7644     7636       -8     
- Partials     1574     1576       +2
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gavinkflam
Copy link
Contributor Author

/cc @saschagrunert @bitoku

Could you PTAL? I noticed that my last PR didn't update the crio.conf.5 document.

saschagrunert
saschagrunert approved these changes Sep 9, 2025
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

Thank you for the update!

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 9, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gavinkflam, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2025
@saschagrunert
Copy link
Member

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit d3b6c3c into cri-o:main Sep 9, 2025
84 of 85 checks passed
@gavinkflam gavinkflam deleted the 5715-runtime-handler-seccomp-profile-docs branch September 9, 2025 12:13
@github-actions github-actions bot mentioned this pull request Sep 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@hasan4791 hasan4791 Awaiting requested review from hasan4791

@klihub klihub Awaiting requested review from klihub

@bitoku bitoku Awaiting requested review from bitoku

Assignees

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gavinkflam @saschagrunert