Skip to content

[release-1.34] : OCPBUGS-59403: HighPerformanceHooks: Atomic locking and fix container replacement race conditions #9481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 2, 2025
Merged

[release-1.34] : OCPBUGS-59403: HighPerformanceHooks: Atomic locking and fix container replacement race conditions #9481

merged 4 commits into from
Oct 2, 2025
+429 −57

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #9405

/assign haircommander

None

@andreaskaris
HighPerformanceHooks: Make locks atomic for irq SMP affinity
e294f54 
A prior patch addressing race conditions in this code section was
incomplete as it used 2 different locks for irqbalance and irq SMP
affinity files. This still allowed for a race condition wrt irqbalance
configuration. This fix addresses this issue by using a single lock and
by making the entire change atomic.

Signed-off-by: Andreas Karis <ak.karis@gmail.com>
@andreaskaris
HighPerformanceHooks: Add mock infra for command and system unit tests
0790633 
Add unit tests for irq smp affinity settings. In order to do so, add
service and command manager structures that can be mocked.

Signed-off-by: Andreas Karis <ak.karis@gmail.com>
@andreaskaris
HighPerformanceHooks: Move IRQ balancing to PostStop hook
c2eab18 
Having IRQ balancing logic inside the PreStop hook can cause issues with
ordering (possibility to hit sequence container add, replacement
container add, container stop). Moving the same logic into PostStop will
guarantee correct ordering.

Signed-off-by: Andreas Karis <ak.karis@gmail.com>
@andreaskaris
HighPerformanceHooks: Defer irqSMPAffinityFile rollback
7561efe 
Signed-off-by: Andreas Karis <ak.karis@gmail.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 30, 2025
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Could not make automatic cherrypick of Jira Issue OCPBUGS-59403 for this PR as the target version is not set for this branch in the jira plugin config. Running refresh:
/jira refresh

/retitle [release-1.34] : HighPerformanceHooks: Atomic locking and fix container replacement race conditions

In response to this:

This is an automated cherry-pick of #9405

/assign haircommander

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 30, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 30, 2025
@openshift-ci openshift-ci bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Sep 30, 2025
@openshift-ci-robot
Copy link

@openshift-ci-robot: This pull request references Jira Issue OCPBUGS-59403, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-59403 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

@openshift-cherrypick-robot: Could not make automatic cherrypick of Jira Issue OCPBUGS-59403 for this PR as the target version is not set for this branch in the jira plugin config. Running refresh:
/jira refresh

/retitle [release-1.34] : HighPerformanceHooks: Atomic locking and fix container replacement race conditions

In response to this:

This is an automated cherry-pick of #9405

/assign haircommander

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-1.34] OCPBUGS-59403: HighPerformanceHooks: Atomic locking and fix container replacement race conditions [release-1.34] : HighPerformanceHooks: Atomic locking and fix container replacement race conditions Sep 30, 2025
@openshift-ci openshift-ci bot requested review from bitoku and QiWang19 September 30, 2025 20:22
@openshift-ci-robot openshift-ci-robot removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 30, 2025
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

This is an automated cherry-pick of #9405

/assign haircommander

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@haircommander haircommander changed the title [release-1.34] : HighPerformanceHooks: Atomic locking and fix container replacement race conditions [release-1.34] : OCPBUGS-59403: HighPerformanceHooks: Atomic locking and fix container replacement race conditions Sep 30, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 30, 2025
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-59403, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-59403 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #9405

/assign haircommander

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@haircommander
Copy link
Member

/jira refresh

@openshift-ci-robot
Copy link

@haircommander: This pull request references Jira Issue OCPBUGS-59403, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-59403 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@codecov Codecov
Copy link

codecov bot commented Sep 30, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 73.56322% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.00%. Comparing base (941066d) to head (7561efe).
⚠️ Report is 9 commits behind head on release-1.34.

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.34    #9481      +/-   ##
================================================
- Coverage         67.04%   67.00%   -0.04%     
================================================
  Files               202      202              
  Lines             28043    28085      +42     
================================================
+ Hits              18802    18819      +17     
- Misses             7665     7691      +26     
+ Partials           1576     1575       -1
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andreaskaris
Copy link
Contributor

/retest

@haircommander
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2025
@haircommander
Copy link
Member

/cherry-pick release-1.33

@openshift-cherrypick-robot
Copy link
Author

@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.33 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@andreaskaris
Copy link
Contributor

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 56a0b8b into cri-o:release-1.34 Oct 2, 2025
52 of 54 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-59403: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-59403 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #9405

/assign haircommander

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link
Author

@haircommander: new pull request created: #9491

In response to this:

/cherry-pick release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@bitoku bitoku Awaiting requested review from bitoku

@QiWang19 QiWang19 Awaiting requested review from QiWang19

Assignees

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@openshift-cherrypick-robot @openshift-ci-robot @haircommander @andreaskaris