Skip to content

[release-1.33] server: add real-time memory validation for limit updates #9404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2025
Merged

[release-1.33] server: add real-time memory validation for limit updates #9404

merged 1 commit into from
Aug 14, 2025

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #9385

/assign sohankunkerkar

server: add real-time memory validation for limit updates

@sohankunkerkar
server: validate memory usage before applying limit decreases
8e0dc35 
This change validates memory limits against current usage
from cgroup files instead of stale cAdvisor cache.

Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 13, 2025
Merged
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 13, 2025
@openshift-ci openshift-ci bot requested review from klihub and littlejawa August 13, 2025 15:48
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 13, 2025

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn 8e0dc35 link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov Codecov
Copy link

codecov bot commented Aug 13, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 15.90909% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.95%. Comparing base (fde1f77) to head (8e0dc35).
⚠️ Report is 2 commits behind head on release-1.33.

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.33    #9404      +/-   ##
================================================
- Coverage         48.01%   47.95%   -0.06%     
================================================
  Files               163      164       +1     
  Lines             24137    24177      +40     
================================================
+ Hits              11589    11595       +6     
- Misses            11405    11437      +32     
- Partials           1143     1145       +2
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sohankunkerkar
sohankunkerkar approved these changes Aug 13, 2025
View reviewed changes
Copy link
Member

@sohankunkerkar sohankunkerkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2025
@sohankunkerkar
Copy link
Member

Merging this manually as the merge job is stuck in pool.

@sohankunkerkar sohankunkerkar merged commit eaa7ec8 into cri-o:release-1.33 Aug 14, 2025
51 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohankunkerkar sohankunkerkar sohankunkerkar approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@littlejawa littlejawa Awaiting requested review from littlejawa

Assignees

@sohankunkerkar sohankunkerkar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@openshift-cherrypick-robot @sohankunkerkar