Skip to content

Add support for csi index #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add support for csi index #407

wants to merge 4 commits into from

Conversation

liyao001
Copy link

Hi there,

I've made an enhancement to pybedtools that adds support for the CSI index. The default TBI index fails for chromosomes larger than 512 Mbp, such as barley's chromosome 2H, which spans more than 665 Mbp. This update ensures that users can handle larger genomic regions without encountering indexing failures.

Thanks for considering this enhancement.

Best,
Li

@liyao001 liyao001 mentioned this pull request Apr 26, 2024
Open
@daler
Copy link
Owner

daler commented Apr 27, 2024

Thanks! Can you please add a test to this PR?

@liyao001
Copy link
Author

Certainly! I've extended one of the existing tests (test_tabix) to cover both the default TBI and the new CSI indexes. Additionally, considering the impact on the tabix_contigs function from the previous commit, I've introduced a new test case (test_tabix_contigs_csi) inspired by test_issues::test_issue_180 to ensure comprehensive coverage of the changes. Let me know if there are any further adjustments needed or if you have any other suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liyao001 @daler