-
Notifications
You must be signed in to change notification settings - Fork 8
feat: introduce theming #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Draft since there's a conflict with I also want to add some tests. |
Thanks for the PR :) Yes, falling back to |
Thanks again for the PR. And apologies for the delay in reviewing it. Overall, the approach looks solid. I've created a PR to your fork with some tweaks that I think make sense. I've listed the details in that PR's description. Take a look, and lemme know if anything looks odd or is unclear. Would be great if you could give the new subcommands a spin and generally test out a bunch of workflows. |
I enabled "Allow edits by maintainers", feel free to push on this PR directly. |
Thanks for your contribution! :) |
Was a pleasure working on this repo! I've been using I have a couple use-cases that are not fully covered, expect more contributions 😉 |
Closes #48.
The only thing I don't necessarily like is being forced to
alias hours='hours --theme ...'
.Do you think we can introduce an environment variable to set a default value for the theme (e.g.
HOURS_THEME
)?