add more ways to specify "today" in date range #85
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @dhth, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the flexibility of date range inputs across various commands by introducing support for "today" as an end date. Users can now specify "today" explicitly or implicitly by omitting the end date in a range. This change simplifies date range usage, particularly for current-day reporting, and updates the command-line interface to reflect these new capabilities.
Highlights
- Enhanced Date Range Flexibility: The system now recognizes "today" as a valid end date for date ranges, either by explicitly using the keyword (e.g., "2024/06/08...today") or by omitting the end date entirely (e.g., "2024/06/08...").
- Improved User Guidance: The command-line help messages for
report,log, andstatscommands have been updated to reflect the newly supported date range formats, providing clear examples to users. - Removed Date Range Limit: As per the changelog, the explicit range limit enforcement for stats and log commands has been removed, allowing for potentially larger date ranges.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces new ways to specify date ranges by allowing an open-ended range to default to "today" and also by allowing the use of the "today" keyword. The changes are well-implemented with corresponding updates to documentation and tests. I've identified a minor copy-paste error in a command's help text and a more significant issue in GetDateRangeFromPeriod where it incorrectly uses time.Now() instead of the provided now parameter, which affects testability. Addressing these points will improve the quality of the changes.
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the date range parsing functionality to support specifying "today" in multiple ways. It allows users to omit the end date (e.g., "2024/06/08...") or explicitly use "today" as the end date (e.g., "2024/06/08...today") when specifying date ranges.
Key changes:
- Modified
parseDateRangefunction to accept anowparameter and handle empty or "today" end dates - Updated test cases to cover the new functionality with proper mocking of current time
- Updated CLI help text to document the new date range format options
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/types/date_helpers.go | Modified parseDateRange to accept now parameter and handle empty/"today" end dates |
| internal/types/date_helpers_test.go | Added test cases for new date range formats and improved test structure |
| cmd/root.go | Updated help text to document new date range format options |
| CHANGELOG.md | Documented the new features in the unreleased section |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.