internal/ui/ui.go (2)

12-15: Nit: variable name reads truncated; prefer clearer error identifier

errCouldnCreateFramesDir reads like a truncated “couldn’t”. Consider errCouldNotCreateFramesDir for clarity.

Apply this diff:

 var (
   errFailedToConfigureDebugging = errors.New("failed to configure debugging")
-  errCouldnCreateFramesDir      = errors.New("couldn't create frames directory")
+  errCouldNotCreateFramesDir    = errors.New("couldn't create frames directory")
 )

Follow-up: update references accordingly (see below).

---

31-31: Update usage to match the renamed error (if you apply the nit above)

-      return fmt.Errorf("%w: %s", errCouldnCreateFramesDir, err.Error())
+      return fmt.Errorf("%w: %s", errCouldNotCreateFramesDir, err.Error())

internal/ui/view.go (2)

33-33: ANSI stripping regex is minimal; consider more general CSI coverage

This only matches SGR color codes (ending in ‘m’). If the output ever includes other CSI sequences, broaden the regex:

-var ansiRegex = regexp.MustCompile(`\x1b\[[0-9;]*m`)
+// Match general ANSI CSI sequences (ESC [ ... final byte in @-~)
+var ansiRegex = regexp.MustCompile(`\x1b\[[0-9;?]*[ -/]*[@-~]`)

This remains safe and covers more cases without pulling a new dependency.

---

320-331: Side-effectful frame logging in View is acceptable for a debug flag; consider throttling if it becomes too noisy

As written, every render writes a file. That’s okay behind m.logFrames, but if perf/noise becomes an issue, consider deduping identical consecutive frames or sampling (e.g., every Nth frame).

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting

internal/ui/view.go (1)

413-420: Fix shadowing of the filepath package and tighten file perms (frames may contain sensitive content)

The local variable named filepath shadows the imported package name and is confusing. Also, frames can include task details; default 0644 makes them world-readable. Prefer a distinct variable name and 0600 perms.

Apply this diff:

-	filename := fmt.Sprintf("%d.txt", frameIndex)
-	filepath := filepath.Join(framesDir, filename)
-
-	_ = os.WriteFile(filepath, []byte(cleanContent), 0o644)
+	filename := fmt.Sprintf("%d.txt", frameIndex)
+	outPath := filepath.Join(framesDir, filename)
+
+	// Restrictive perms; frames can contain task details
+	_ = os.WriteFile(outPath, []byte(cleanContent), 0o600)

internal/ui/model.go (1)

135-137: Minor type nit: consider avoiding architecture-dependent uint

Using plain uint ties the width to the architecture. If you ever serialize or compare across processes, consider int or uint64 for consistency. Not blocking.

internal/ui/view.go (1)

33-34: ANSI stripping regex is narrowly scoped to SGR “m”; consider a more general CSI matcher

If you ever render other control sequences (cursor movement, erase line, etc.), this won’t strip them. Optional, but safer long-term.

Apply this diff:

-var ansiRegex = regexp.MustCompile(`\x1b\[[0-9;]*m`)
+// Match CSI sequences broadly: ESC [ <params> <intermediates> <final-byte>
+var ansiRegex = regexp.MustCompile(`\x1b\[[0-?]*[ -/]*[@-~]`)

internal/ui/ui.go (2)

34-40: Avoid per-run directory collisions and prefer private perms

Two processes started within the same second could share the same “.frames/<unix_seconds>” directory. Also, for privacy, prefer 0700 over 0755.

Apply this diff:

-		framesDir := filepath.Join(".frames", fmt.Sprintf("%d", time.Now().Unix()))
-		err := os.MkdirAll(framesDir, 0o755)
+		base := ".frames"
+		// Ensure base exists with private perms
+		if err := os.MkdirAll(base, 0o700); err != nil {
+			return fmt.Errorf("%w: %s", errCouldnCreateFramesDir, err.Error())
+		}
+		// Use higher-resolution timestamp to reduce collision risk
+		framesDir := filepath.Join(base, fmt.Sprintf("%d", time.Now().UnixNano()))
+		err := os.MkdirAll(framesDir, 0o700)

---

16-16: Nit: fix typo in error identifier

Minor readability polish: errCouldnCreateFramesDir → errCouldntCreateFramesDir.

Apply this diff:

-	errCouldnCreateFramesDir      = errors.New("couldn't create frames directory")
+	errCouldntCreateFramesDir     = errors.New("couldn't create frames directory")

And update its usage:

-			return fmt.Errorf("%w: %s", errCouldnCreateFramesDir, err.Error())
+			return fmt.Errorf("%w: %s", errCouldntCreateFramesDir, err.Error())

Also applies to: 37-37

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting