Update Bencher CLI usage #4335
Open
Update Bencher CLI usage #4335
+36
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi @epompeii , Thanks for the PR!
The changes are good overall just a formatting change I've suggested for you to look into.
.github/workflows/track_benches.yml
Outdated
| core.exportVariable("PR_HEAD", `${githubEvent.pull_request.head.ref}-${githubEvent.pull_request.head.sha.slice(0, 8)}`); | ||
| core.exportVariable("PR_ID", `${githubEvent.pull_request.head.ref}/${process.env.BENCHER_TESTBED}/${process.env.BENCHER_ADAPTER}`); | ||
| core.exportVariable("PR_NUMBER", githubEvent.number); | ||
| core.exportVariable("PR_HEAD", prEvent.pull_request.head.ref); |
There was a problem hiding this comment.
The variable prEvent is not present here, we can use the githubEvent instead.
There was a problem hiding this comment.
Great catch! Fixed.
bc4c1fd
to
8377219
Compare
This changeset updates the Bencher CLI to the new recommended usage. - Update deprecated CLI options: https://bencher.dev/docs/explanation/branch-selection/ - Safer and more succinct tracking from forks: https://bencher.dev/docs/how-to/github-actions/#pull-requests-from-forks - Threshold creation as a part of `bencher run`: https://bencher.dev/docs/explanation/thresholds/ - Use `percentage` test: https://bencher.dev/docs/explanation/thresholds/#percentage
8377219
to
3d3493f
Compare
PratikFandade
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset updates the Bencher CLI to the new recommended usage.
bencher run: https://bencher.dev/docs/explanation/thresholds/percentagetest: https://bencher.dev/docs/explanation/thresholds/#percentage