Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kanban layout selection mode #23489

Merged
merged 10 commits into from
Aug 27, 2024
Merged

Conversation

hanneskuettner
Copy link
Member

Scope

Add selection implementation for the Kanban layout by extracting out common logic of table and calendar click handlers to common composable.

Demo Time!

CleanShot.2024-08-26.at.19.48.28.mp4

What's changed:

  • Add useLayoutClickHandler that handles common logic
  • Add selection highlighting to Kanban layout
  • Make Kanban unchangeable when in selection mode to prevent accidental reordering of items and groups

Potential Risks / Drawbacks

  • I broke some other selection logic, I tested all impacted layout tho

Review Notes / Questions

  • N/A

Fixes #21492

Copy link

changeset-bot bot commented Aug 26, 2024

🦋 Changeset detected

Latest commit: ec999b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@directus/app Minor
@directus/api Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@AlexGaillard AlexGaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through this pretty carefully, and I think it LGTM.

Just one small style thought really? But if we think it's not worth doing then I'm happy to approve.

app/src/layouts/kanban/kanban.vue Show resolved Hide resolved
@AlexGaillard AlexGaillard self-assigned this Aug 27, 2024
Copy link
Member

@AlexGaillard AlexGaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexGaillard AlexGaillard merged commit 0737935 into main Aug 27, 2024
4 checks passed
@AlexGaillard AlexGaillard deleted the fix-21492-kanban-selection-mode branch August 27, 2024 19:32
@github-actions github-actions bot added this to the Next Release milestone Aug 27, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't select items in the kanban layout
2 participants