-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kanban layout selection mode #23489
Conversation
🦋 Changeset detectedLatest commit: ec999b1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Hannes Küttner <kuettner.hannes@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through this pretty carefully, and I think it LGTM.
Just one small style thought really? But if we think it's not worth doing then I'm happy to approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Scope
Add selection implementation for the Kanban layout by extracting out common logic of table and calendar click handlers to common composable.
Demo Time!
CleanShot.2024-08-26.at.19.48.28.mp4
What's changed:
useLayoutClickHandler
that handles common logicPotential Risks / Drawbacks
Review Notes / Questions
Fixes #21492