Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix group detail collapse on save and stay action #23099

Merged
merged 6 commits into from
Jul 26, 2024
Merged

Fix group detail collapse on save and stay action #23099

merged 6 commits into from
Jul 26, 2024

Conversation

SP12893678
Copy link
Contributor

Scope

When save article with "Save and Stay", it will refresh to fetch latest data, and then group detail would be collapsed by loading status changed.

It will be displayed by the setting rules , not keep user operation status

What's changed:

  • Add a mechanism to check is first lodaing or not

Reproduce setting

bandicam.2024-07-24.23-57-10-977.mp4

Reproduce demo

bandicam.2024-07-24.23-57-38-832.mp4

Fixed demo

bandicam.2024-07-24.23-59-38-770.mp4

Potential Risks / Drawbacks

Review Notes / Questions

  • N/A

Fixes #20968

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 24, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 986426d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@SP12893678 SP12893678 force-pushed the fix/#20968-group-detail-collapse-on-save-and-stay branch from 3bdd19c to 2786d2e Compare July 24, 2024 16:39
rijkvanzanten
rijkvanzanten requested changes Jul 24, 2024
View reviewed changes
Copy link
Member

@rijkvanzanten rijkvanzanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be a good use case for Vue's new { once: true } option in the watcher! https://vuejs.org/guide/essentials/watchers#once-watchers

I've never tried them myself, but it sounds like that's what we need in this case right? 🤔

@SP12893678
Copy link
Contributor Author

This might be a good use case for Vue's new { once: true } option in the watcher! https://vuejs.org/guide/essentials/watchers#once-watchers

I've never tried them myself, but it sounds like that's what we need in this case right? 🤔

Thanks for the suggestion!
Its a better usage!😆

@SP12893678 SP12893678 force-pushed the fix/#20968-group-detail-collapse-on-save-and-stay branch from fb96c66 to f64a2d1 Compare July 25, 2024 01:42
@rijkvanzanten rijkvanzanten merged commit 7123692 into directus:main Jul 26, 2024
1 check passed
@github-actions github-actions bot added this to the Next Release milestone Jul 26, 2024
@SP12893678 SP12893678 deleted the fix/#20968-group-detail-collapse-on-save-and-stay branch August 2, 2024 12:32
@faustro faustro mentioned this pull request Aug 28, 2024
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rijkvanzanten rijkvanzanten rijkvanzanten approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
v10.13.2
Development

Successfully merging this pull request may close these issues.

Detail groups collapse on save-and-stay
2 participants
@SP12893678 @rijkvanzanten