Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust permissions migration to work with more MySQL flavors #23327

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

hanneskuettner
Copy link
Member

@hanneskuettner hanneskuettner commented Aug 13, 2024

Scope

The migration was failing on some MySQL flavors and configurations, for example AWS Aurora MySQL.
This change moves the foreign key creation to after all modifications on the policy column have been finished.

Potential Risks / Drawbacks

  • Potential for this breaking on other DB vendors, I tested this on Postgres, Cockroach (since it was picky on the initial migration approach) and SQlite so far

Review Notes / Questions

  • I would like to lorem ipsum
  • I've got a working AWS Aurora running, if anyone needs credentials for testing

Fixes #23281, fixed #23234

Copy link

changeset-bot bot commented Aug 13, 2024

🦋 Changeset detected

Latest commit: d2b67b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@directus/api Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎸 (Comparable to what we did in #19407 👍)

@paescuj paescuj merged commit 434b8e8 into main Aug 14, 2024
4 checks passed
@paescuj paescuj deleted the fix-23281-mysql-migration branch August 14, 2024 09:32
@github-actions github-actions bot added this to the Next Release milestone Aug 14, 2024
@maholick
Copy link

That is just awesome! Thank so much. 🤘🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants