BindableLayout should dispatch layout changes when collection changes from background thread #24714
+43
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @albyrock87! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
mattleibow
requested changes
Sep 11, 2024
There was a problem hiding this comment.
This looks good. I wonder why we never dispatched before.
@PureWeen not sure if this rings any bells. I recall EZ was always sad we did dispatching for some things and we should have always done something different. But I may be mixing multiple thoughts here...
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
… from background thread
affaee5
to
1cc4786
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Adding the do not merge as I believe this is still undergoing discussions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Quoting https://learn.microsoft.com/en-us/dotnet/maui/fundamentals/data-binding/?view=net-maui-8.0
In MAUI we're used to
Bindingmarshaling, so when doingBindableLayout.ItemsSource={Binding MyCollection}we give for granted this will be automatically marshaled to the main thread which is true forINotifyPropertyChangedevent.maui/src/Controls/src/Core/BindingExpression.cs
Line 717 in c4479e6
maui/src/Controls/src/Core/BindingExpression.cs
Line 742 in c4479e6
INotifyCollectionChanged(likeINotifyPropertyChanged) should be also taken into account in this context.This is the main cause of the issue #10918 reported a while ago.
This PR introduces the use of
IDispatcherwhen reacting to collection changed event.Issues Fixed
Fixes #10918