Fixed NavigationPage Title property #24781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @Vignesh-SF3580! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
rmarinho
approved these changes
Sep 24, 2024
redducks100
pushed a commit
to redducks100/maui
that referenced
this pull request
Sep 24, 2024
* Fixed-19859 : NavigationPage: Title not updating * test cases added. * testcases updated. * updated Issue19859.xaml * Added snapshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause
The issue occurred because the title was being updated based on the current page in the
NavigationPage, which prevented theNavigationPage's title from being updated correctly.Description of Change
The fix ensures that the
NavigationPage's title is now updated when it is notnull, so the correct title is always displayed.Tested the behaviour in the following platforms
Issues Fixed
Fixes #19859
Screenshots
Before
After
