This repository has been archived by the owner on Nov 24, 2020. It is now read-only.
Fix AutoSizeColumn #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thanks for your PR, AutoSizeColumn is a bug in the migration process. It is not an easy task to completely solve this problem. Anyway, thank you very much for your work. :) |
yang-xiaodong
approved these changes
Oct 11, 2018
|
I'll release a new version tomorrow |
I discovered that this is true. It showed up in my project because NPOI was first referenced from a netstandard2.0 library and that library referenced by net461 (NPOI -> netstandard -> net461). All that to say, my fixes work nearly perfect for NPOI net461 but are slightly off in NPOI netstandard2.0. I'll see if I'm able to submit another fix for netstandard at a later time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77 and part of #74.
The existing AutoSizeColumn unit tests pass now and the new calculations seem to be working great.
Unfortunately, when I reference NPOI indirectly from a net461 ASP.NET project some of the columns are sized slightly smaller than the content. While debugging I determined it's because
Graphics.MeasureStringreturns a different value in this context. I'm not sure why. My first thought was the method returns a different value inSystem.DrawingthanSystem.Drawing.Common, but that doesn't explain why the sizing works fine from the unit test project which is also net461. I thinkSystem.Drawing.Commonjust delegates to GDI+ likeSystem.Drawingdoes anyway.I can't spend much more time looking into it, so thoughts and additional testing are welcome. Otherwise, I think it works well enough to merge considering the current version doesn't auto-size at all.