Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump golang.org/x/net from 0.28.0 to 0.29.0 in /tools/mod #18597

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build(deps): bump golang.org/x/net from 0.28.0 to 0.29.0 in /tools/mod #18597

wants to merge 1 commit into from
+3 −3

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 16, 2024

Bumps golang.org/x/net from 0.28.0 to 0.29.0.

Commits
  • 35b4aba go.mod: update golang.org/x dependencies
  • 9bf379f websocket: fix printf(var) mistake detected by latest printf checker
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
build(deps): bump golang.org/x/net from 0.28.0 to 0.29.0 in /tools/mod
9f60746 
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.28.0 to 0.29.0.
- [Commits](golang/net@v0.28.0...v0.29.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Sep 16, 2024
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot[bot]
Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.81%. Comparing base (7f399ee) to head (a4368c7).

❗ Current head a4368c7 differs from pull request most recent head 9f60746

Please upload reports for the commit 9f60746 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 24 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18597      +/-   ##
==========================================
+ Coverage   68.78%   68.81%   +0.02%     
==========================================
  Files         420      420              
  Lines       35474    35474              
==========================================
+ Hits        24402    24412      +10     
+ Misses       9652     9639      -13     
- Partials     1420     1423       +3

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f399ee...9f60746. Read the comment docs.

@henrybear327
Copy link
Contributor

Before

➜  etcd git:(main) grep -Ri "golang.org/x/net v" | grep -v sum
./etcdutl/go.mod:       golang.org/x/net v0.28.0 // indirect
./go.mod:       golang.org/x/net v0.28.0 // indirect
./tools/testgrid-analysis/go.mod:       golang.org/x/net v0.28.0 // indirect
./tools/mod/go.mod:     golang.org/x/net v0.28.0 // indirect
./etcdctl/go.mod:       golang.org/x/net v0.28.0 // indirect
./tests/go.mod: golang.org/x/net v0.28.0 // indirect
./server/go.mod:        golang.org/x/net v0.28.0
./api/go.mod:   golang.org/x/net v0.28.0 // indirect
./client/v3/go.mod:     golang.org/x/net v0.28.0 // indirect
./pkg/go.mod:   golang.org/x/net v0.28.0 // indirect

@henrybear327
Copy link
Contributor

After

➜  etcd git:(dependencies/09_18_24) ✗ grep -Ri "golang.org/x/net v" | grep -v sum
./etcdutl/go.mod:       golang.org/x/net v0.29.0 // indirect
./go.mod:       golang.org/x/net v0.29.0 // indirect
./tools/testgrid-analysis/go.mod:       golang.org/x/net v0.29.0 // indirect
./tools/rw-heatmaps/go.mod:     golang.org/x/net v0.29.0 // indirect
./tools/mod/go.mod:     golang.org/x/net v0.29.0 // indirect
./etcdctl/go.mod:       golang.org/x/net v0.29.0 // indirect
./tests/go.mod: golang.org/x/net v0.29.0 // indirect
./server/go.mod:        golang.org/x/net v0.29.0
./api/go.mod:   golang.org/x/net v0.29.0 // indirect
./client/internal/v2/go.mod:    golang.org/x/net v0.29.0 // indirect
./client/v3/go.mod:     golang.org/x/net v0.29.0 // indirect
./pkg/go.mod:   golang.org/x/net v0.29.0 // indirect

henrybear327 added a commit to henrybear327/etcd that referenced this pull request Sep 18, 2024
@henrybear327
dependency: bump golang.org/x/net from 0.28.0 to 0.29.0
8868a68 
Reference:
- etcd-io#18597

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/tooling dependencies Pull requests that update a dependency file go Pull requests that update Go code needs-ok-to-test size/XS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k8s-ci-robot @codecov-commenter @henrybear327