Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annex 2 and 3 typos #195

Merged
merged 7 commits into from
Jun 28, 2024
Merged

Annex 2 and 3 typos #195

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
751f1a7
Annex 2: Use plural acronym HLRs consistently
toonn Jun 14, 2024
1b2a881
Annex 2: Use e.g. instead of i.e.
toonn Jun 14, 2024
5490994
Annex 3 PID Rulebook: Add missing "in"
toonn Jun 14, 2024
67678c1
Annex 3 PID Rulebook: Use not-equals for other than age_over_NN
toonn Jun 14, 2024
64ba3e4
Annex 3 PID Rulebook: Correct article, remove double in, add missing …
toonn Jun 14, 2024
49617eb
Annex 3 PID Rulebook: Rephrase to change meaning
toonn Jun 14, 2024
33b6902
Annex 3 PID Rulebook: Add missing period after section reference
toonn Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Annex 3 PID Rulebook: Correct article, remove double in, add missing … 
…period

The indefinite article for "SD-JWT-compliant encoding," should be "an."
Two common ways to determine the proper article are by eliding the
adjective "an encoding" or pronouncing the acronym "an ess-dee..."
  • Loading branch information
@toonn
toonn committed Jun 14, 2024
commit 64ba3e48635bb18e1661ee143a231aa225f4552a
7 changes: 4 additions & 3 deletions docs/annexes/annex-3/annex-3.01-pid-rulebook.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,17 +380,18 @@ specified in \[SD-JWT VC\] must be used. For the latter, attributes must
be encoded in JSON. For the former, attributes must be encoded in CBOR.

This section therefore specifies two separate encodings for the PID data
model, an ISO/IEC 18013-5-compliant encoding in CBOR, and a
model, an ISO/IEC 18013-5-compliant encoding in CBOR, and an
SD-JWT-compliant encoding in JSON.

#### 2.4.2 ISO/IEC 18013-5-compliant encoding

##### 2.4.2.1 Encoding rules

If attributes specified in in Table 1 are encoded with CBOR, they SHALL
If attributes specified in Table 1 are encoded with CBOR, they SHALL
be encoded as specified in \[[RFC 8949](https://datatracker.ietf.org/doc/html/rfc8949)\].

The CDDL representation types used in Table 1 are specified in [section 2.3.1](#231-introduction-introduction-1) Rules to encode CDDL representation types with CBOR are specified
The CDDL representation types used in Table 1 are specified in [section 2.3.1](#231-introduction-introduction-1).
Rules to encode CDDL representation types with CBOR are specified in
\[RFC 8610\] and \[[RFC 8949](https://datatracker.ietf.org/doc/html/rfc8949)\].

##### 2.4.2.2 Further stipulations
Expand Down