Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tools] Move tools/expotools one folder up #11410

Merged
merged 3 commits into from
Dec 21, 2020
Merged

[tools] Move tools/expotools one folder up #11410

merged 3 commits into from
Dec 21, 2020

Conversation

tsapeta
Copy link
Member

@tsapeta tsapeta commented Dec 18, 2020 •
edited
Loading

Why

Entirely closes #4428

How

Shortly: tools/expotools is now just tools

Test Plan

Running expotools command works as expected and the CI agrees with that 😉

@github-actions
Copy link
Contributor

Native Component List for this branch is ready

@tsapeta tsapeta force-pushed the @tsapeta/et/move-up-expotools branch from efe48c4 to 7db0ab8 Compare December 19, 2020 18:56
@tsapeta tsapeta marked this pull request as ready for review December 19, 2020 19:15
bbarthec
bbarthec reviewed Dec 21, 2020
View reviewed changes
Copy link
Contributor

@bbarthec bbarthec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks about right to me 👍
But there seems to be a discrepancy between folder name and what's inside (tools vs expotools). I don't like it TBH. Mind changing the folder to expotools? 🤔

@tsapeta
Copy link
Member Author

tsapeta commented Dec 21, 2020

Since expotools are actually the only tools-system that left (we had tools, tools-public and expotools), there is no longer a need to distinguish tools and expotools. It seemed more obvious to me to stay with tools directory name, as it's semantically more correct because the directory, in fact, contains some tools.

Moreover, I think we should start thinking of it as Expo tools, not expotools 😉

@tsapeta tsapeta force-pushed the @tsapeta/et/move-up-expotools branch from 7db0ab8 to ff572bf Compare December 21, 2020 18:12
@tsapeta tsapeta merged commit eeffdb1 into master Dec 21, 2020
@tsapeta tsapeta deleted the @tsapeta/et/move-up-expotools branch December 21, 2020 18:51
This was referenced Dec 23, 2020
Open
Open
Open
This was referenced Aug 29, 2021
Open
Open
Open
This was referenced Jan 18, 2022
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request May 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbarthec bbarthec bbarthec left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tools] Merge tools, tools-public and expotools
2 participants
@tsapeta @bbarthec