[ios][calendar] Fix url parsing when adding url in calendar event and reminder #24102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
lukmccall
reviewed
Sep 11, 2023
lukmccall
approved these changes
Sep 22, 2023
I'm sorry, I completely missed your comment! |
brentvatne
pushed a commit
that referenced
this pull request
Sep 25, 2023
… reminder (#24102) # Why Resolves #13804 (the issue closed but the issue was actually never fixed) When adding a url to an event or a reminder in expo-calendar, the entire url is url-encoded and it cannot be used # How Use `NSURLComponents componentsWithString` that correctly parses the url passed as string (see [doc](https://developer.apple.com/documentation/foundation/nsurlcomponents/1572054-componentswithstring?language=objc)) and set `url` in `calendarEvent` or `reminder` if `URL` of `URLComponents` is not `nil` # Test Plan Tested locally in my application by updating the source code # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Resolves #13804 (the issue closed but the issue was actually never fixed)
When adding a url to an event or a reminder in expo-calendar, the entire url is url-encoded and it cannot be used
How
Use
NSURLComponents componentsWithStringthat correctly parses the url passed as string (see doc) and seturlincalendarEventorreminderifURLofURLComponentsis notnilTest Plan
Tested locally in my application by updating the source code
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).