Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][Android] SharedObjectTypeConverter now can work with Dynamic objects #24207

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

lukmccall
Copy link
Contributor

Why

Allows us to pass SharedObject as a prop. Note: It'll steal the required small workaround in JS to convert the shared object to int.

Test Plan

  • tbd

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Aug 31, 2023
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Sep 1, 2023
@lukmccall lukmccall merged commit 4955e3a into main Sep 1, 2023
1 check passed
@lukmccall lukmccall deleted the @lukmccall/core/extend-shared-object-type-converter branch September 1, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants