[modules-core] Add macOS support #26186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68de3da
to
08825de
Compare
Kudo
reviewed
Jan 2, 2024
| @@ -44,12 +43,32 @@ - (id)forwardingTargetForSelector:(SEL)selector | |||
|
|
|||
| #if __has_include(<React-RCTAppDelegate/RCTAppDelegate.h>) || __has_include(<React_RCTAppDelegate/RCTAppDelegate.h>) | |||
|
|
|||
| - (UIView *)findRootView:(UIApplication *)application | |||
There was a problem hiding this comment.
didn't see any code to use the new method?
There was a problem hiding this comment.
Oops, looks like it remained here after resolving conflicts. You removed that method a while ago 😅
Edit: I removed it from here!
| @@ -69,7 +88,7 @@ - (UIView *)createRootViewWithBridge:(RCTBridge *)bridge | |||
| moduleName:moduleName | |||
| initialProperties:initProps | |||
| fabricEnabled:enableFabric]; | |||
| #if !TARGET_OS_TV | |||
| #if !TARGET_OS_TV && !TARGET_OS_OSX | |||
| rootView.backgroundColor = UIColor.systemBackgroundColor; | |||
There was a problem hiding this comment.
not sure whether we should use NSColor.windowBackgroundColor for macos?
There was a problem hiding this comment.
NSView doesn't have the backgroundColor property, but looks like we can change that on its layer. I'll change it.
Co-authored-by: Kudo Chien <kudo@expo.dev>
Kudo
approved these changes
Jan 3, 2024
This was referenced Jan 3, 2024
tsapeta
added a commit
that referenced
this pull request
Jan 10, 2024
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Adds support for macOS platform to the
expo-modules-corepackage. It's been separated from #22796.How
react-native-macosdoes, but we need to expose that to Swift.Platform.hif needed).Test Plan
Tested in https://github.com/tsapeta/expo-macos-example as part of the bigger PR #22796