-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[expo-asset] Clean up some asset stuff #26310
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschurman
force-pushed
the
@wschurman/clean-up-some-asset
branch
from
January 8, 2024 22:10
ebc9ae8
to
adc0136
Compare
wschurman
requested review from
ide and
douglowder
and removed request for
tsapeta
January 9, 2024 03:32
ide
approved these changes
Jan 9, 2024
tsapeta
approved these changes
Jan 9, 2024
wschurman
force-pushed
the
@wschurman/clean-up-some-asset
branch
from
January 9, 2024 18:56
adc0136
to
a4a57cd
Compare
expo-bot
added
bot: passed checks
ExpoBot has nothing to complain about
and removed
bot: suggestions
ExpoBot has some suggestions
labels
Jan 9, 2024
github-actions
bot
added
bot: fingerprint changed
and removed
bot: fingerprint compatible
labels
Jan 9, 2024
@wschurman Will those changes be included in SDK 50? Not sure if need to backport data for them. Asking because I'm currently working on the TypeDoc update, and spotted that the docs data has not been regenerated, and also due to the latest changes in package code some docs tests are failing. |
@Simek - nope, this is for 51. |
Simek
added a commit
that referenced
this pull request
Jan 11, 2024
…#26343) # Why Update TypeDoc to the latest release to keep up to day and officially support package source build with TS 5.2+. All data files have been changed, since TypeDoc removed on of legacy the entry Kind enum values (`ObjectLiteral`) which caused a shift of existing values after it. # How Update TypeDoc to the latest version, rewrite TypeDoc Application calls execution, update Docs snapshot and unit tests to match the data. Unfortunately, the data generation command outputs not valid for our use case warning due to TypeStrong/typedoc#2440, but it doesn't matter in our case due to using the JSON data only, and custom renderers, which can handle both comment structures correctly, so those warning can be ignored. We can alter source comments in the future, when stable SDK 50 will be releases to avoid shipping large amount of changes in preview/RC stage. > [!important] > No backport of `expo-assets` data for SDK 50 has been made due to #26310, which probably did not become part od SDK 50, but if will land, we will need to backport the package data, since the structure and exported fields have changed. # Test Plan The changes have been reviewed locally. Reference doc pages contains a full, and expected data. All lint checks and tests are passing.
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
…expo#26343) # Why Update TypeDoc to the latest release to keep up to day and officially support package source build with TS 5.2+. All data files have been changed, since TypeDoc removed on of legacy the entry Kind enum values (`ObjectLiteral`) which caused a shift of existing values after it. # How Update TypeDoc to the latest version, rewrite TypeDoc Application calls execution, update Docs snapshot and unit tests to match the data. Unfortunately, the data generation command outputs not valid for our use case warning due to TypeStrong/typedoc#2440, but it doesn't matter in our case due to using the JSON data only, and custom renderers, which can handle both comment structures correctly, so those warning can be ignored. We can alter source comments in the future, when stable SDK 50 will be releases to avoid shipping large amount of changes in preview/RC stage. > [!important] > No backport of `expo-assets` data for SDK 50 has been made due to expo#26310, which probably did not become part od SDK 50, but if will land, we will need to backport the package data, since the structure and exported fields have changed. # Test Plan The changes have been reviewed locally. Reference doc pages contains a full, and expected data. All lint checks and tests are passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bot: fingerprint changed
bot: passed checks
ExpoBot has nothing to complain about
published
Changes from the PR have been published to npm
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This PR is just in preparation for further cleanup, and just does some typescript cleanup.
Closes ENG-10968.
How
Read code, clean up where possible.
Test Plan
tsc
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).