Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expo-asset] Clean up some asset stuff #26310

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

wschurman
Copy link
Member

@wschurman wschurman commented Jan 8, 2024

Why

This PR is just in preparation for further cleanup, and just does some typescript cleanup.

Closes ENG-10968.

How

Read code, clean up where possible.

Test Plan

tsc

Checklist

Copy link

linear bot commented Jan 8, 2024

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jan 8, 2024
@wschurman wschurman force-pushed the @wschurman/clean-up-some-asset branch from ebc9ae8 to adc0136 Compare January 8, 2024 22:10
@wschurman wschurman marked this pull request as ready for review January 9, 2024 03:32
@wschurman wschurman requested review from ide and douglowder and removed request for tsapeta January 9, 2024 03:32
@wschurman wschurman force-pushed the @wschurman/clean-up-some-asset branch from adc0136 to a4a57cd Compare January 9, 2024 18:56
@wschurman wschurman merged commit fd16cf8 into main Jan 9, 2024
13 checks passed
@wschurman wschurman deleted the @wschurman/clean-up-some-asset branch January 9, 2024 18:56
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jan 9, 2024
@Simek
Copy link
Collaborator

Simek commented Jan 10, 2024

@wschurman Will those changes be included in SDK 50? Not sure if need to backport data for them.

Asking because I'm currently working on the TypeDoc update, and spotted that the docs data has not been regenerated, and also due to the latest changes in package code some docs tests are failing.

@wschurman
Copy link
Member Author

@Simek - nope, this is for 51.

Simek added a commit that referenced this pull request Jan 11, 2024
…#26343)

# Why

Update TypeDoc to the latest release to keep up to day and officially
support package source build with TS 5.2+.

All data files have been changed, since TypeDoc removed on of legacy the
entry Kind enum values (`ObjectLiteral`) which caused a shift of
existing values after it.

# How

Update TypeDoc to the latest version, rewrite TypeDoc Application calls
execution, update Docs snapshot and unit tests to match the data.

Unfortunately, the data generation command outputs not valid for our use
case warning due to TypeStrong/typedoc#2440,
but it doesn't matter in our case due to using the JSON data only, and
custom renderers, which can handle both comment structures correctly, so
those warning can be ignored. We can alter source comments in the
future, when stable SDK 50 will be releases to avoid shipping large
amount of changes in preview/RC stage.

> [!important]
> No backport of `expo-assets` data for SDK 50 has been made due to
#26310, which probably did not become part od SDK 50, but if will land,
we will need to backport the package data, since the structure and
exported fields have changed.

# Test Plan

The changes have been reviewed locally. Reference doc pages contains a
full, and expected data. All lint checks and tests are passing.
onizam95 pushed a commit to onizam95/expo-av-drm that referenced this pull request Jan 15, 2024
onizam95 pushed a commit to onizam95/expo-av-drm that referenced this pull request Jan 15, 2024
…expo#26343)

# Why

Update TypeDoc to the latest release to keep up to day and officially
support package source build with TS 5.2+.

All data files have been changed, since TypeDoc removed on of legacy the
entry Kind enum values (`ObjectLiteral`) which caused a shift of
existing values after it.

# How

Update TypeDoc to the latest version, rewrite TypeDoc Application calls
execution, update Docs snapshot and unit tests to match the data.

Unfortunately, the data generation command outputs not valid for our use
case warning due to TypeStrong/typedoc#2440,
but it doesn't matter in our case due to using the JSON data only, and
custom renderers, which can handle both comment structures correctly, so
those warning can be ignored. We can alter source comments in the
future, when stable SDK 50 will be releases to avoid shipping large
amount of changes in preview/RC stage.

> [!important]
> No backport of `expo-assets` data for SDK 50 has been made due to
expo#26310, which probably did not become part od SDK 50, but if will land,
we will need to backport the package data, since the structure and
exported fields have changed.

# Test Plan

The changes have been reviewed locally. Reference doc pages contains a
full, and expected data. All lint checks and tests are passing.
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants