[camera] Fix web imports #26505
Merged
[camera] Fix web imports #26505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukmccall
approved these changes
Jan 19, 2024
|
This bug still exists if you create a new Expo Repository, and setup a fresh component of Expo Camera. It will error on Web. @alanjhughes @brentvatne @lukmccall |
|
@WatchmansEase - can you share a minimal reproducible example repository please? https://stackoverflow.com/help/minimal-reproducible-example |
|
@WatchmansEase - what version of |
|
@WatchmansEase - I've just tested this in a new expo project and it is working on web |
|
@alanjhughes My apologies and my thanks - upgrading to |
|
@WatchmansEase - no problem 👍 glad it's working for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes #26504
Files were renamed to
ExpoCamerabut the web specific files were stillExponentCameraleading to an error when importing on web.How
Renamed the files.
Test Plan
Tested in a local project. Web specific files are found and work correctly.