[core][tools] fix build error for react-native@0.74.0-nightly-20240121-a58ec074b #26587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matinzd
reviewed
Jan 22, 2024
| "Bold" -> 700 | ||
| "Black" -> 900 | ||
| - else -> UNSET | ||
| + else -> -1 |
There was a problem hiding this comment.
Is it safe to use -1 here? What if something changes in the future? Are they going to make it public again so that libraries using this API won't break?
There was a problem hiding this comment.
@matinzd it looks not safe, i don't have much insight of how text processing between react-native and lottie-react-native. it's just an intermediate patch for us to fix breaking changes before 3rd party libs publish new versions.
323e7f7
to
6db4334
Compare
lukmccall
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
react-native nightlies testing is broken on 0.74.0-nightly-20240121-a58ec074b
How
Spannableon Android facebook/react-native#39630 (comment)Test Plan
ci passed (test-suite and test-suite-nightly)
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).