Bump androidx.browser:browser to 1.6.0 #26619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsapeta
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Looks good to me, thanks for the contribution!
cc @alanjhughes to confirm if you're fine with this change.
alanjhughes
approved these changes
Jan 23, 2024
|
Small, probably unrelated issue with the CI: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Our product can be embed in our clients applications, using in-app browser. But we noticed that the clients using Expo suffers from issues when it cames to WebAuthn.
As we were not able to reproduce in our bare react-native implementation example, we noticed that
expo-web-browseris using a quite old version of the dependency.This PR bump the dependency to
1.6.0.1.7.0is not doable at the moment as it requirescompileSdkto at least34and would drop Expo 49 support:EDIT: I also added updating the
expo-dev-menumodule dependency as installing the two at the same time would leads to conflicts if the deps versions does not align.How
Just bump the dependency version. There's no breaking changes and it appears to be safe.
Test Plan
Test that the module continues to behaves correctly.
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).