[asset] fix reentrant promise resolving crash #27672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Pull Request introduced fingerprint changes against the base commit: ec64e1a Fingerprint diff[
{
"type": "dir",
"filePath": "../../packages/expo-asset/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "bc2b8da4c5c6f0883232bb4ee0f11806f024b49d"
}
]Generated by PR labeler 🤖 |
3fa8ef9
to
33008d8
Compare
33008d8
to
a2c5fad
Compare
d55c0c6
to
2eab47d
Compare
3 tasks
tsapeta
approved these changes
Mar 15, 2024
| @@ -20,6 +20,7 @@ public class AssetModule: Module { | |||
| AsyncFunction("downloadAsync") { (url: URL, md5Hash: String?, type: String, promise: Promise) in | |||
| if url.isFileURL { | |||
| promise.resolve(url.standardizedFileURL.absoluteString) | |||
There was a problem hiding this comment.
Maybe resolve/reject should have the return type Never so it basically requires to be the last expression within the block? 🤔
There was a problem hiding this comment.
Maybe resolve/reject should have the return type
Neverso it basically requires to be the last expression within the block? 🤔
i'll leave it to you and merge the pr first for fixing ci. thanks!
Kudo
added a commit
that referenced
this pull request
Mar 15, 2024
# Why investigating test-suite ios failure. this one is a regression from #27601 and caused `Linking.getInitialURL()` returns null when launching app with deep links. # How pass the launchOptions to the bridge # Test Plan - kill bare-expo process and run `xcrun simctl openurl booted 'bareexpo://test-suite/run?tests=Basic'` should go to the basic test screen - ci passed especially for test-suite ios - this pr is stacked on top of #27672 and should work to fix test-suite
marklawlor
pushed a commit
that referenced
this pull request
Mar 18, 2024
# Why ios bare-expo release build was crashing because of "Tried to resolve a promise more than once." # How i think we should have early return after resolving the promise.
marklawlor
pushed a commit
that referenced
this pull request
Mar 18, 2024
# Why investigating test-suite ios failure. this one is a regression from #27601 and caused `Linking.getInitialURL()` returns null when launching app with deep links. # How pass the launchOptions to the bridge # Test Plan - kill bare-expo process and run `xcrun simctl openurl booted 'bareexpo://test-suite/run?tests=Basic'` should go to the basic test screen - ci passed especially for test-suite ios - this pr is stacked on top of #27672 and should work to fix test-suite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
ios bare-expo release build was crashing because of "Tried to resolve a promise more than once."
How
i think we should have early return after resolving the promise.
Test Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).