[updates] fix error recovery on android #27815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Pull Request introduced fingerprint changes against the base commit: 796d42a Fingerprint diff[
{
"type": "dir",
"filePath": "../../packages/expo-modules-core/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "de8d3310de13d9a5605e3879286bb29fd04443eb"
},
{
"type": "dir",
"filePath": "../../packages/expo-updates/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "d1e2a67bbf7990d98ba4b62369007d725ac32645"
},
{
"type": "dir",
"filePath": "../../packages/expo/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "dde693a1c8cad65bef7da0050bcd720f99343ed1"
}
]Generated by PR labeler 🤖 |
82ad034
to
3f20d49
Compare
3f20d49
to
8eff6d1
Compare
lukmccall
approved these changes
Mar 27, 2024
|
the sdk check-packages failure would be fixed by #27891 |
wschurman
requested changes
Mar 27, 2024
...dates/android/src/main/java/expo/modules/updates/procedures/RecreateReactContextProcedure.kt
Outdated
Show resolved
Hide resolved
...ages/expo-updates/android/src/main/java/expo/modules/updates/procedures/RelaunchProcedure.kt
Outdated
Show resolved
Hide resolved
| @@ -245,6 +245,10 @@ class StartupProcedure( | |||
| errorRecovery.startMonitoring(reactContext) | |||
| } | |||
|
|
|||
| fun onReactInstanceException(exception: Exception) { | |||
| errorRecovery.handleException(exception) | |||
There was a problem hiding this comment.
since overriding the exception handler doesn't work on bridgeless, should we update ErrorRecovery to not register the error when in bridgeless mode?
edit: I see that the registration is done in onDidCreateReactInstanceManager/onDidCreateReactInstance so it shouldn't be running on bridgeless. let's add an assert to registerErrorHandler to assert non-bridgeless and also add an assert to onReactInstanceException (here) to assert bridgeless, just so that if upstream (expo-modules-core) is changed our assumptions hold.
There was a problem hiding this comment.
tried to split that as two different implementation, hopes that looks good
private fun registerErrorHandler(reactContext: ReactContext) {
if (ReactFeatureFlags.enableBridgelessArchitecture) {
registerErrorHandlerImplBridgeless(reactContext)
} else {
registerErrorHandlerImplBridge(reactContext)
}
}
douglowder
reviewed
Mar 27, 2024
...-modules-core/android/src/main/java/expo/modules/core/interfaces/ReactNativeHostHandler.java
Outdated
Show resolved
Hide resolved
douglowder
reviewed
Mar 27, 2024
...-modules-core/android/src/main/java/expo/modules/core/interfaces/ReactNativeHostHandler.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Will Schurman <wschurman@expo.io> Co-authored-by: Douglas Lowder <douglowder@mac.com>
8eff6d1
to
16526fd
Compare
tsapeta
approved these changes
Apr 1, 2024
wschurman
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
add bridgeless support for expo-updates's error recovery on android
close ENG-11707
How
DefaultJSExceptionHandlerfrom DevSupportManager doesn't work on bridgeless mode. we should add aReactNativeHostHandler.onReactInstanceExceptionto pull the exception from ReactHostReactApplication.restart()to support both bridgeless and bridge mode.Test Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).