[web-browser] Fix issue when the browser is dismissed quickly #28452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Pull Request introduced fingerprint changes against the base commit: 1eccf32 Fingerprint diff[
{
"type": "dir",
"filePath": "../../packages/expo-web-browser/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "a3689bd1cb825a8e26e2dbcf70f27cc04e525209"
}
]Generated by PR labeler 🤖 |
tsapeta
approved these changes
Apr 29, 2024
| @@ -169,25 +167,11 @@ export async function openBrowserAsync( | |||
| throw new UnavailabilityError('WebBrowser', 'openBrowserAsync'); | |||
| } | |||
|
|
|||
| if (browserLocked) { | |||
There was a problem hiding this comment.
Is it safe to remove on Android?
There was a problem hiding this comment.
Android uses intents, it always navigates away from the app so it had no guards anyway. It's not possible to call it twice. I think this was aimed at iOS specifically.
There was a problem hiding this comment.
Did just notice one issue, dismissBrowser shouldn't be called on android.
tsapeta
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes #27197
Opening and dismissing the browser quickly causes the delegates not to be called. This leaves the module in a state where it can no longer be used because it thinks there is still an active browser session.
How
We were controlling locking the api from the JS side. This needs the delegates to be called to resolve the promise. We can't rely on the delegates being called but we can know if we have presented the view controller. I've added a check if the controller has been presented. If it has when
openBrowserAsynchas been called we can assume that it was called and dismissed quickly and set the session tonil.Test Plan
Tested in bare-expo, rapidly opening and closing the browser. Everything seems to be working fine. Seen as we recreate the session, there's no risk of resolving the same promise twice.