[expo-print][android] Migrate the expo-print module to the new modules API #21714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
lukmccall
requested changes
Mar 15, 2023
packages/expo-print/android/src/main/java/expo/modules/print/PrintDocumentAdapter.kt
Outdated
Show resolved
Hide resolved
packages/expo-print/android/src/main/java/expo/modules/print/PrintExceptions.kt
Outdated
Show resolved
Hide resolved
packages/expo-print/android/src/main/java/expo/modules/print/PrintExceptions.kt
Outdated
Show resolved
Hide resolved
packages/expo-print/android/src/main/java/expo/modules/print/PrintExceptions.kt
Outdated
Show resolved
Hide resolved
packages/expo-print/android/src/main/java/expo/modules/print/PrintModule.kt
Outdated
Show resolved
Hide resolved
packages/expo-print/android/src/main/java/expo/modules/print/PrintOptions.kt
Outdated
Show resolved
Hide resolved
lukmccall
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Expo-print was written using the old API, the docs were missing description of the differences between Android and iOS in
printAsyncpromise resolving.How
Converted to new modules API, modified the module to use kotlin Coroutines. Updated the docs to make the differences between Android and iOS clearer. There was also an unnecessary
@platform ioslabel inPrintOptions.urias this option also works on Android.Test Plan
Tested the library on a physical printer and print to file on a physical device.