[ios] [image-manipulator] Fix issue when manipulating image with unsupported color space #21757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
d2e653b
to
c3760cd
Compare
|
@lukmccall any chance I can get a review on this? |
…pported color space
c3760cd
to
2375d5b
Compare
lukmccall
approved these changes
Mar 29, 2023
EvanBacon
pushed a commit
that referenced
this pull request
Apr 5, 2023
…pported color space (#21757) # Why When using expo-image-manipulator to resize an image (https://docs.expo.dev/versions/latest/sdk/imagemanipulator/#methods), if the provided image is in a color space that iOS cannot output to, the manipulateAsync method will fail. # How Accomplishes this with a simple code change of using the default device's RGB colorspace when the image's colorspace does not suffice. # Test Plan Using this image: https://user-images.githubusercontent.com/192928/225686623-db8d4cb1-1d96-4345-8b9e-e4fbd1083e39.png call ``` await ImageManipulator.manipulateAsync(attachment.uri, [{ resize: attachment.height > attachment.width ? { height: 1500 } : { width: 1500 }, }], { compress: 0.9, }, ); ``` and the method should succeed. # Checklist - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [x] This diff will work correctly for `expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When using expo-image-manipulator to resize an image (https://docs.expo.dev/versions/latest/sdk/imagemanipulator/#methods), if the provided image is in a color space that iOS cannot output to, the manipulateAsync method will fail.
How
Accomplishes this with a simple code change of using the default device's RGB colorspace when the image's colorspace does not suffice.
Test Plan
Using this image: https://user-images.githubusercontent.com/192928/225686623-db8d4cb1-1d96-4345-8b9e-e4fbd1083e39.png
call
and the method should succeed.
Checklist
expo prebuild& EAS Build (eg: updated a module plugin).