[ios][speech] Migrate to Expo Modules #21814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88f43ef
to
4253af0
Compare
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
expo-bot
reviewed
Mar 23, 2023
|
|
||
| struct VoiceInfo: Record { | ||
| @Field | ||
| var identifier: String? = nil |
There was a problem hiding this comment.
🟠 SwiftLint: Redundant Optional Initialization Violation
Initializing an optional variable with nil is redundant.
| @Field | ||
| var identifier: String? = nil | ||
| @Field | ||
| var name: String? = nil |
There was a problem hiding this comment.
🟠 SwiftLint: Redundant Optional Initialization Violation
Initializing an optional variable with nil is redundant.
| @Field | ||
| var name: String? = nil | ||
| @Field | ||
| var quality: String? = nil |
There was a problem hiding this comment.
🟠 SwiftLint: Redundant Optional Initialization Violation
Initializing an optional variable with nil is redundant.
| @Field | ||
| var quality: String? = nil | ||
| @Field | ||
| var language: String? = nil |
There was a problem hiding this comment.
🟠 SwiftLint: Redundant Optional Initialization Violation
Initializing an optional variable with nil is redundant.
tsapeta
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Continue migrating modules to Expo modules API
How
Followed typical migration steps
Test Plan
Tested in bare expo app