[android][image-picker] Support for cameraType #22143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added support for cameraType on android - Updated types to include cameraType - Documented the undocumented cameraType
lukmccall
requested changes
Apr 17, 2023
...expo-image-picker/android/src/main/java/expo/modules/imagepicker/contracts/CameraContract.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Łukasz Kosmaty <kosmatylukasz@gmail.com>
Co-authored-by: Łukasz Kosmaty <kosmatylukasz@gmail.com>
|
Please fix |
|
@lukmccall Done! Retry the test when you get the chance. |
|
@lukmccall You can retry the test now and all should be good. |
|
All that's missing now is a final review |
lukmccall
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
cameraTypeoption was missing for android, and only implemented in iOS.cameraTypewere missingHow
Intentextras that tell the camera app which camera to use by defaultCameraTypesimilarly to how expo-camera currently implements it for consistency. (Maybe should be a shared type?)Test Plan
bare-expoapp on Androidexpo-image-pickerand launched the camera with different values forcameraTypeChecklist
expo prebuild& EAS Build (eg: updated a module plugin).