Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-native 0.72.0-rc.5 #22588

Merged
merged 48 commits into from
Jun 7, 2023
Merged
Show file tree
Hide file tree
Changes from 43 commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
3778e33
[core] fix use_frameworks with new arch
Kudo Feb 27, 2023
4dd433a
update package versions
Kudo May 17, 2023
e0b7dbf
[templates][tabs] remove metro version overrides
Kudo May 17, 2023
284f947
bump react-native-web to 0.19.4
Kudo May 17, 2023
e5908e6
update yarn.lock
Kudo May 17, 2023
4ea8643
[bare-expo] migrate to 0.72
Kudo May 17, 2023
8bb8caf
[templates] migrate bare template to 0.72
Kudo May 17, 2023
d8ecfe6
[fabric-tester] migrate to 0.72 by expo prebuild
Kudo Jun 6, 2023
48bfd88
more install_modules_dependencies
Kudo May 17, 2023
8491d61
[android] fix react-native path movement from monorepo changes
Kudo May 19, 2023
802f07a
[android] Fix gradle 8 errors
Kudo May 19, 2023
33de68a
[react-native-lab] update to 0.72
Kudo May 19, 2023
203730c
[bare-expo] add java8 workaround
Kudo May 19, 2023
c0df0a2
fix build errors for react-native monorepo changes
Kudo May 19, 2023
5095c20
[ios] fix build error
Kudo May 19, 2023
ec97e7a
[tools] update vendoring script for rn monorepo changes
Kudo May 19, 2023
172cb6f
fixup gradle workaround
Kudo May 19, 2023
795b8ce
use prebuild detox to fix detox slider build error
Kudo May 22, 2023
23890f6
Revert "bump react-native-web to 0.19.4"
Kudo May 23, 2023
7103f5e
update yarn.lock
Kudo May 23, 2023
6999845
[cli] temporarily disable typecheck because metro upgrade
Kudo May 23, 2023
39d0f70
[ncl] remove deprecated ProgressViewIOS/ProgressBarAndroid
Kudo May 23, 2023
15bd15a
[ncl] fix TextInputScreen type error
Kudo May 23, 2023
5ddb63c
[cli] fix unit test metro import paths
Kudo May 23, 2023
a388cc5
[react-native-lab] update to 0.72.0-rc.5
Kudo Jun 1, 2023
8dcfcc6
react-native 0.72.0-rc.5
Kudo Jun 1, 2023
74e053d
bump metro-react-native-babel-preset
Kudo Jun 1, 2023
e28391d
update yarn.lock
Kudo Jun 1, 2023
ebf9ab0
update podfile.lock
Kudo Jun 1, 2023
8c50dc4
[dev-launcher] update bundles
Kudo Jun 1, 2023
d5191d6
[dev-menu] update bundles
Kudo Jun 1, 2023
47c1840
Revert "fixup gradle workaround"
Kudo Jun 1, 2023
2cff80f
Revert "[bare-expo] add java8 workaround"
Kudo Jun 1, 2023
82fc21b
[config-plugins] fix broken test because of template changes
Kudo Jun 1, 2023
31b94dc
[metro-config] fix typescript error
Kudo Jun 1, 2023
e00b45c
[image] fix typescript error, let's see how it going after react-nati…
Kudo Jun 1, 2023
c29b5dd
update changelog
Kudo Jun 6, 2023
d83dcdb
[prebuild-config] update snapshot for template change
Kudo Jun 6, 2023
79cd425
increase android ci timeout
Kudo Jun 6, 2023
2ad501b
update yarn.lock
Kudo Jun 6, 2023
11d33ef
[autolinking] add missing modules for new architecture mode
Kudo Jun 6, 2023
60e4787
[core] fix nullable eventDispatcher on new architecture mode
Kudo Jun 6, 2023
c7519cf
[eas-expo-go] fix error from file movement
Kudo Jun 6, 2023
808819c
[updates] skip broken test
Kudo Jun 7, 2023
0f689a8
Apply suggestions from code review
Kudo Jun 7, 2023
3ad6c80
Apply suggestions from code review
Kudo Jun 7, 2023
aa9d586
Apply suggestions from code review
Kudo Jun 7, 2023
6ae301b
[eas-expo-go] update cache key
Kudo Jun 7, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/actions/expo-caches/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -175,14 +175,14 @@ runs:
uses: actions/cache@v3
with:
path: android/prebuiltHermes
key: hermes-engine-aar-v2-${{ hashFiles('react-native-lab/react-native/sdks/.hermesversion') }}
key: hermes-engine-aar-v2-${{ hashFiles('react-native-lab/react-native/packages/react-native/sdks/.hermesversion') }}
- name: Check hermes-engine cache-hit
if: inputs.hermes-engine-aar == 'true'
id: cache-hermes-engine-aar
shell: bash
run: |
CURRENT_VERSION=$(test -f android/prebuiltHermes/.hermesversion && cat android/prebuiltHermes/.hermesversion) || true
TARGET_VERSION=$(test -f react-native-lab/react-native/sdks/.hermesversion && cat react-native-lab/react-native/sdks/.hermesversion) || true
TARGET_VERSION=$(test -f react-native-lab/react-native/packages/react-native/sdks/.hermesversion && cat react-native-lab/react-native/packages/react-native/sdks/.hermesversion) || true
if [[ $CURRENT_VERSION == $TARGET_VERSION ]]; then
echo "cache-hit=true" >> $GITHUB_OUTPUT
else
Expand All @@ -195,11 +195,11 @@ runs:
# Ensure node packages are installed when yarn-workspace cache miss
yarn install --frozen-lockfile
mkdir -p prebuiltHermes
cp -f ../react-native-lab/react-native/sdks/.hermesversion prebuiltHermes/
./gradlew :ReactAndroid:hermes-engine:assembleRelease
./gradlew :ReactAndroid:hermes-engine:assembleDebug
cp -f ../react-native-lab/react-native/ReactAndroid/hermes-engine/build/outputs/aar/hermes-engine-release.aar prebuiltHermes/
cp -f ../react-native-lab/react-native/ReactAndroid/hermes-engine/build/outputs/aar/hermes-engine-debug.aar prebuiltHermes/
cp -f ../react-native-lab/react-native/packages/react-native/sdks/.hermesversion prebuiltHermes/
./gradlew :packages:react-native:ReactAndroid:hermes-engine:assembleRelease
./gradlew :packages:react-native:ReactAndroid:hermes-engine:assembleDebug
cp -f ../react-native-lab/react-native/packages/react-native/ReactAndroid/hermes-engine/build/outputs/aar/hermes-engine-release.aar prebuiltHermes/
cp -f ../react-native-lab/react-native/packages/react-native/ReactAndroid/hermes-engine/build/outputs/aar/hermes-engine-debug.aar prebuiltHermes/
env:
# Reset reactNativeArchitectures to build all architectures
ORG_GRADLE_PROJECT_reactNativeArchitectures:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/android-instrumentation-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ concurrency:
jobs:
test:
runs-on: macos-12
timeout-minutes: 120
timeout-minutes: 150
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📈

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

building hermes requires more time than usual 🤦‍♂️

env:
ORG_GRADLE_PROJECT_reactNativeArchitectures: x86_64
GRADLE_OPTS: -Dorg.gradle.jvmargs=-Xmx2048m -XX:MaxMetaspaceSize=1024m
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/cli.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ jobs:
- name: 🧶 Install node modules in root dir
if: steps.expo-caches.outputs.yarn-workspace-hit != 'true'
run: yarn install --frozen-lockfile
- name: 🔎 Type Check CLI
run: yarn typecheck
working-directory: packages/@expo/cli
# - name: 🔎 Type Check CLI
# run: yarn typecheck
# working-directory: packages/@expo/cli
- name: 🛠 Build CLI
run: yarn prepare
working-directory: packages/@expo/cli
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ xcuserdata
ReactAndroid-temp.aar
/android/prebuiltHermes
/android/versioned-abis/**/*.aar
/android/packages/react-native/sdks/hermes
Kudo marked this conversation as resolved.
Show resolved Hide resolved

# Tools
jarjar-rules.txt
Expand Down
8 changes: 4 additions & 4 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ plugins {
// WHEN_DISTRIBUTING_REMOVE_TO_HERE

def reactProperties = new Properties()
file("${project(':ReactAndroid').projectDir}/gradle.properties").withInputStream { reactProperties.load(it) }
file("${project(':packages:react-native:ReactAndroid').projectDir}/gradle.properties").withInputStream { reactProperties.load(it) }

allprojects {
repositories {
Expand Down Expand Up @@ -91,13 +91,13 @@ allprojects {
// WHEN_DISTRIBUTING_REMOVE_FROM_HERE
resolutionStrategy.dependencySubstitution {
substitute(module("com.facebook.react:react-native"))
.using(project(":ReactAndroid"))
.using(project(":packages:react-native:ReactAndroid"))
.because("Building React Native from source")
substitute(module("com.facebook.react:react-native:+"))
.using(project(":ReactAndroid"))
.using(project(":packages:react-native:ReactAndroid"))
.because("Building React Native from source")
substitute(module("com.facebook.react:react-android"))
.using(project(":ReactAndroid"))
.using(project(":packages:react-native:ReactAndroid"))
.because("Building React Native from source")
}
// WHEN_DISTRIBUTING_REMOVE_TO_HERE
Expand Down
22 changes: 10 additions & 12 deletions android/expoview/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -6,27 +6,19 @@ apply plugin: 'kotlin-kapt'
apply from: new File(rootDir, "versioning_linking.gradle")

def reactProperties = new Properties()
file("${project(':ReactAndroid').projectDir}/gradle.properties").withInputStream { reactProperties.load(it) }
file("${project(':packages:react-native:ReactAndroid').projectDir}/gradle.properties").withInputStream { reactProperties.load(it) }

// WHEN_VERSIONING_REMOVE_FROM_HERE
//maven repository info
group = 'host.exp.exponent'
version = '45.0.0'

// Creating sources with comments
task androidSourcesJar(type: Jar) {
classifier = 'sources'
from android.sourceSets.main.java.srcDirs
}

afterEvaluate {
publishing {
publications {
// use `versionedRelease` configuration when publishing to maven
versionedRelease(MavenPublication) {
from components.versionedRelease
// Add additional sourcesJar to artifacts
artifact(androidSourcesJar)
}
}
repositories {
Expand All @@ -40,7 +32,7 @@ afterEvaluate {

def prebuiltHermesDir = findProperty("expo.prebuiltHermesDir") ?: file("${rootDir}/prebuiltHermes")
def prebuiltHermesVersion = file("${prebuiltHermesDir}/.hermesversion").exists() ? file("${prebuiltHermesDir}/.hermesversion").text : null
def currentHermesVersion = file("${project(':ReactAndroid').projectDir}/../sdks/.hermesversion").exists() ? file("${project(':ReactAndroid').projectDir}/../sdks/.hermesversion").text : null
def currentHermesVersion = file("${project(':packages:react-native:ReactAndroid').projectDir}/../sdks/.hermesversion").exists() ? file("${project(':packages:react-native:ReactAndroid').projectDir}/../sdks/.hermesversion").text : null
def buildHermesSource = currentHermesVersion != prebuiltHermesVersion
logger.info(":expoview - buildHermesSource[${buildHermesSource}]")

Expand Down Expand Up @@ -132,6 +124,12 @@ android {

// use `versionedRelease` configuration when publishing to maven
defaultPublishConfig "versionedRelease"

publishing {
singleVariant("release") {
withSourcesJar()
}
}
}

// WHEN_VERSIONING_REMOVE_FROM_HERE
Expand Down Expand Up @@ -190,13 +188,13 @@ dependencies {

api 'org.webkit:android-jsc:r250231' // needs to be before react-native

api project(':ReactAndroid')
api project(':packages:react-native:ReactAndroid')

if (!buildHermesSource) {
debugImplementation(files("${prebuiltHermesDir}/hermes-engine-debug.aar"))
releaseImplementation(files("${prebuiltHermesDir}/hermes-engine-release.aar"))
} else {
implementation(project(':ReactAndroid:hermes-engine')) {
implementation(project(':packages:react-native:ReactAndroid:hermes-engine')) {
exclude(group:'com.facebook.fbjni', module: 'fbjni')
}
}
Expand Down
8 changes: 4 additions & 4 deletions android/settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ includeBuild('../react-native-lab/react-native/packages/react-native-gradle-plug

include ':expoview'
include ':tools'
include ':ReactAndroid'
project(':ReactAndroid').projectDir = new File(rootDir, '../react-native-lab/react-native/ReactAndroid')
include ':ReactAndroid:hermes-engine'
project(':ReactAndroid:hermes-engine').projectDir = new File(rootDir, '../react-native-lab/react-native/ReactAndroid/hermes-engine')
include ':packages:react-native:ReactAndroid'
project(':packages:react-native:ReactAndroid').projectDir = new File(rootDir, '../react-native-lab/react-native/packages/react-native/ReactAndroid')
include ':packages:react-native:ReactAndroid:hermes-engine'
project(':packages:react-native:ReactAndroid:hermes-engine').projectDir = new File(rootDir, '../react-native-lab/react-native/packages/react-native/ReactAndroid/hermes-engine')
include ':expo-modules-test-core'
project(':expo-modules-test-core').projectDir = new File(rootDir, '../packages/expo-modules-test-core/android')

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@

public class ReactAndroidCodeTransformer {

private static final String REACT_ANDROID_DEST_ROOT = "react-native-lab/react-native/ReactAndroid";
private static final String REACT_ANDROID_DEST_ROOT = "react-native-lab/react-native/packages/react-native/ReactAndroid";
private static final String SOURCE_PATH = "src/main/java/com/facebook/react/";

private static abstract class MethodVisitor {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@ tasks.all({ task ->
if (rootProject.ext.has('reactNativeAndroidRoot')) {
defaultDir = rootProject.ext.get('reactNativeAndroidRoot')
androidSourcesDir = defaultDir.parentFile.toString()
} else if (findProject(':ReactAndroid') != null) {
} else if (findProject(':packages:react-native:ReactAndroid') != null) {
sourceBuild = false
defaultDir = project(':ReactAndroid').projectDir
defaultDir = project(':packages:react-native:ReactAndroid').projectDir
androidSourcesDir = defaultDir.parentFile.toString()
} else {
defaultDir = file("$nodeModules/versioned-react-native/android")
Expand All @@ -81,7 +81,7 @@ if (!defaultDir.exists()) {
}

def prebuiltDir = sourceBuild
? Paths.get(findProject(":ReactAndroid").getProjectDir().toString(), "build", "intermediates", "library_*", "*", "jni")
? Paths.get(findProject(":packages:react-native:ReactAndroid").getProjectDir().toString(), "build", "intermediates", "library_*", "*", "jni")
: "$buildDir/reactandroid-abi*/jni"


Expand Down Expand Up @@ -208,27 +208,6 @@ dependencies {
}
}

afterEvaluate { project ->
task androidSourcesJar(type: Jar) {
classifier = 'sources'
from android.sourceSets.main.java.srcDirs
include '**/*.java'
}

android.libraryVariants.all { variant ->
def name = variant.name.capitalize()
def javaCompileTask = variant.javaCompileProvider.get()

task "jar${name}"(type: Jar, dependsOn: javaCompileTask) {
from javaCompileTask.destinationDir
}
}

artifacts {
archives androidSourcesJar
}
}

task extractAARHeaders {
doLast {
configurations.extractHeaders.files.each {
Expand Down Expand Up @@ -275,10 +254,10 @@ tasks.whenTaskAdded { task ->
if (!task.name.contains("Clean") && (task.name.contains('externalNativeBuild') || task.name.startsWith('configureCMake'))) {
if (sourceBuild) {
def currentBuildType = task.name.endsWith('Debug') ? 'Debug' : 'Release'
task.dependsOn(":ReactAndroid:copy${currentBuildType}JniLibsProjectOnly")
task.dependsOn(":packages:react-native:ReactAndroid:copy${currentBuildType}JniLibsProjectOnly")
}
} else if (task.name.startsWith('generateJsonModel') && sourceBuild) {
def currentBuildType = task.name.endsWith('Debug') ? 'Debug' : 'Release'
task.dependsOn(":ReactAndroid:copy${currentBuildType}JniLibsProjectOnly")
task.dependsOn(":packages:react-native:ReactAndroid:copy${currentBuildType}JniLibsProjectOnly")
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ def kotlin_version = safeExtGet('kotlinVersion', project.properties['RNGH_kotlin
dependencies {
//noinspection GradleDynamicVersion
if (isNewArchitectureEnabled()) {
implementation project(':ReactAndroid')
implementation project(':packages:react-native:ReactAndroid')
} else {
implementation 'host.exp:reactandroid-abi47_0_0:1.0.0'
compileOnly 'com.facebook.fbjni:fbjni:+'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ if (CLIENT_SIDE_BUILD) {
def reactNativeRootDir = Paths.get(projectDir.getPath(), '../../../../versioned-react-native').toFile()

def reactProperties = new Properties()
file("$reactNativeRootDir/../../react-native-lab/react-native/ReactAndroid/gradle.properties").withInputStream { reactProperties.load(it) }
file("$reactNativeRootDir/../../react-native-lab/react-native/packages/react-native/ReactAndroid/gradle.properties").withInputStream { reactProperties.load(it) }

def BOOST_VERSION = reactProperties.getProperty("BOOST_VERSION")
def DOUBLE_CONVERSION_VERSION = reactProperties.getProperty("DOUBLE_CONVERSION_VERSION")
Expand Down Expand Up @@ -614,7 +614,7 @@ Task resolveFolly = resolveTaskFactory("resolveFolly", "folly-${FOLLY_VERSION}.t
Task resolveGlog = resolveTaskFactory("resolveGlog", "glog-${GLOG_VERSION}.tar.gz", reactNativeAndroidDownloadDir, downloadsDir)

if (isNewArchitectureEnabled()) {
def reactNativeAndroidProject = findProject(":ReactAndroid")
def reactNativeAndroidProject = findProject(":packages:react-native:ReactAndroid")
if (reactNativeAndroidProject != null) {
reactNativeAndroidProject.afterEvaluate {
def resolveTasks = [resolveBoost, resolveGlog, resolveDoubleConversion, resolveFolly]
Expand All @@ -624,13 +624,13 @@ if (isNewArchitectureEnabled()) {
if (reactAndroidDownloadTask != null) {
task.dependsOn(reactAndroidDownloadTask)
} else {
logger.warn("[Reanimated] Failed to find task named `$reactAndroidDownloadTaskName` in `:ReactAndroid` project." +
logger.warn("[Reanimated] Failed to find task named `$reactAndroidDownloadTaskName` in `:packages:react-native:ReactAndroid` project." +
" Explicit dependency between it and $task.name task can not be set.")
}
})
}
} else {
throw new GradleScriptException("[Reanimated] Failed to find `:ReactAndroid` project. Explicit dependency between download tasks can not be set.")
throw new GradleScriptException("[Reanimated] Failed to find `:packages:react-native:ReactAndroid` project. Explicit dependency between download tasks can not be set.")
}
}

Expand Down Expand Up @@ -1026,7 +1026,7 @@ if (CLIENT_SIDE_BUILD) {
tasks.whenTaskAdded { task ->
def buildType = task.name.endsWith('Debug') ? 'Debug' : 'Release'
if (!task.name.contains("Clean") && (task.name.contains('externalNativeBuild') || task.name.startsWith('configureCMake') || task.name.startsWith('buildCMake') || task.name.startsWith('generateJsonModel'))) {
task.dependsOn(":ReactAndroid:copy${buildType}JniLibsProjectOnly")
task.dependsOn(":packages:react-native:ReactAndroid:copy${buildType}JniLibsProjectOnly")
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ repositories {

dependencies {
if (isNewArchitectureEnabled()) {
implementation project(":ReactAndroid")
implementation project(":packages:react-native:ReactAndroid")
} else {
implementation 'host.exp:reactandroid-abi47_0_0:1.0.0'
compileOnly 'com.facebook.fbjni:fbjni:+'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ def defaultDir

if (rootProject.ext.has('reactNativeAndroidRoot')) {
defaultDir = rootProject.ext.get('reactNativeAndroidRoot')
} else if (findProject(':ReactAndroid') != null) {
} else if (findProject(':packages:react-native:ReactAndroid') != null) {
sourceBuild = false
defaultDir = project(':ReactAndroid').projectDir
defaultDir = project(':packages:react-native:ReactAndroid').projectDir
} else {
defaultDir = file("$nodeModules/react-native")
}
Expand Down Expand Up @@ -220,27 +220,6 @@ dependencies {
}
}

afterEvaluate { project ->
task androidSourcesJar(type: Jar) {
classifier = 'sources'
from android.sourceSets.main.java.srcDirs
include '**/*.java'
}

android.libraryVariants.all { variant ->
def name = variant.name.capitalize()
def javaCompileTask = variant.javaCompileProvider.get()

task "jar${name}"(type: Jar, dependsOn: javaCompileTask) {
from javaCompileTask.destinationDir
}
}

artifacts {
archives androidSourcesJar
}
}

task extractAARHeaders {
doLast {
configurations.extractHeaders.files.each {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ if (CLIENT_SIDE_BUILD) {
def reactNativeRootDir = Paths.get(projectDir.getPath(), '../../../../versioned-react-native').toFile()

def reactProperties = new Properties()
file("$rootDir/../react-native-lab/react-native/ReactAndroid/gradle.properties").withInputStream { reactProperties.load(it) }
file("$rootDir/../react-native-lab/react-native/packages/react-native/ReactAndroid/gradle.properties").withInputStream { reactProperties.load(it) }

def REACT_NATIVE_VERSION = reactProperties.getProperty("VERSION_NAME")
def REACT_NATIVE_MINOR_VERSION = REACT_NATIVE_VERSION.startsWith("0.0.0-") ? 1000 : REACT_NATIVE_VERSION.split("\\.")[1].toInteger()
Expand Down Expand Up @@ -734,7 +734,7 @@ if (REACT_NATIVE_MINOR_VERSION < 71) {
Task resolveGlog = resolveTaskFactory("resolveGlog", "glog-${GLOG_VERSION}.tar.gz", reactNativeAndroidDownloadDir, downloadsDir)

if (isNewArchitectureEnabled()) {
def reactNativeAndroidProject = findProject(":ReactAndroid")
def reactNativeAndroidProject = findProject(":packages:react-native:ReactAndroid")
if (reactNativeAndroidProject != null) {
reactNativeAndroidProject.afterEvaluate {
def resolveTasks = [resolveBoost, resolveGlog, resolveDoubleConversion, resolveFolly]
Expand All @@ -744,13 +744,13 @@ if (REACT_NATIVE_MINOR_VERSION < 71) {
if (reactAndroidDownloadTask != null) {
task.dependsOn(reactAndroidDownloadTask)
} else {
logger.warn("[Reanimated] Failed to find task named `$reactAndroidDownloadTaskName` in `:ReactAndroid` project." +
logger.warn("[Reanimated] Failed to find task named `$reactAndroidDownloadTaskName` in `:packages:react-native:ReactAndroid` project." +
" Explicit dependency between it and $task.name task can not be set.")
}
})
}
} else {
throw new GradleException("[Reanimated] Failed to find `:ReactAndroid` project. Explicit dependency between download tasks can not be set.")
throw new GradleException("[Reanimated] Failed to find `:packages:react-native:ReactAndroid` project. Explicit dependency between download tasks can not be set.")
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ repositories {

dependencies {
if (isNewArchitectureEnabled()) {
implementation project(":ReactAndroid")
implementation project(":packages:react-native:ReactAndroid")
} else {
implementation 'host.exp:reactandroid-abi48_0_0:1.0.0'
compileOnly 'com.facebook.fresco:fresco:+'
Expand Down
Loading