Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[android][file-system] Migrate to new modules API #22728

Merged
merged 5 commits into from
Jun 7, 2023
Merged

[android][file-system] Migrate to new modules API #22728

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d39bca2
[android][file-system] Migrate to modules API
alanjhughes Jun 2, 2023
562dcfe
[android][file-system] add changelog
alanjhughes Jun 2, 2023
7aa2642
[android][file-system] handle reading directory correctly
alanjhughes Jun 2, 2023
03d4b7f
[android][file-system] make requested changes
alanjhughes Jun 7, 2023
eb66b51
add back package
alanjhughes Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[android][file-system] add changelog
  • Loading branch information
@alanjhughes
alanjhughes committed Jun 2, 2023
commit 562dcfe16bccf64dd87807d8d5391600285074f6
2 changes: 2 additions & 0 deletions packages/expo-file-system/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

### 🎉 New features

- Migrated Android codebase to use Expo modules API. ([#22728](https://github.com/expo/expo/pull/22728) by [@alanhughes](https://github.com/alanjhughes))

### 🐛 Bug fixes

- Fixed Android build warnings for Gradle version 8. ([#22537](https://github.com/expo/expo/pull/22537), [#22609](https://github.com/expo/expo/pull/22609) by [@kudo](https://github.com/kudo))
Expand Down
9 changes: 8 additions & 1 deletion packages/expo-file-system/android/src/main/java/expo/modules/filesystem/FileSystemRecords.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,14 +69,21 @@ data class WritingOptions(
) : Record

data class FileSystemUploadOptions(
@Field
val headers: Map<String, String>?,
@Field
val httpMethod: HttpMethod = HttpMethod.POST,
@Field
val sessionType: SessionType = SessionType.BACKGROUND,
@Field
val uploadType: FileSystemUploadType,
@Field
val fieldName: String?,
@Field
val mimeType: String?,
@Field
val parameters: Map<String, String>?
)
) : Record

enum class HttpMethod(val value: String) : Enumerable {
POST("POST"),
Expand Down