[constants] Remove deprecated fields #23068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschurman
approved these changes
Jun 23, 2023
tsapeta
approved these changes
Jun 23, 2023
packages/expo-constants/CHANGELOG.md
Outdated
| @@ -4,6 +4,8 @@ | |||
|
|
|||
| ### 🛠 Breaking changes | |||
|
|
|||
| - Remove the long-deprecated `Constants.deviceYearClass` and `Constants.platform.ios.model`. These properties now live on `expo-device`. | |||
There was a problem hiding this comment.
Just move this to others, as we discussed on Slack
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
modelanddeviceYearClasswere slated to be removed in SDK 45. We left them around for a bit longer. G'byeHow
Delete JS and native code, re-generate docs schema.
Test Plan
CI