Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[android][image-picker] Fix backported photo picker crashing with null intent #23224

Merged
merged 2 commits into from
Jul 1, 2023
Merged

[android][image-picker] Fix backported photo picker crashing with null intent #23224

merged 2 commits into from
Jul 1, 2023

Conversation

thespacemanatee
Copy link
Contributor

Why

Resolves #23020

Support both the new photo picker and the old document picker flow.

How

  • Remove the block in AndroidManifest.xml that automatically downloads the backported photo picker on older devices
  • Restore the old Intent creation code
  • Add a isPhotoPickerAvailable check that returns the appropriate Intent

Test Plan

Tested on bare-expo to be working, and on my company's project.

Checklist

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Jun 30, 2023
alanjhughes
alanjhughes approved these changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@alanjhughes alanjhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 🚀 I would like investigate why this isn't working as expected but this is fine until then

@alanjhughes alanjhughes merged commit a5300fd into expo:main Jul 1, 2023
tsapeta pushed a commit that referenced this pull request Jul 3, 2023
@thespacemanatee @tsapeta
[android][image-picker] Fix backported photo picker crashing with nul…
3c25888 
…l intent (#23224)
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Jul 4, 2023
@AquilesOliveiraDev
Copy link

I tested now the latest version 14.3.1 and unfortunately the same problem occurred...

This was referenced Jul 5, 2023
Open
Open
Open
@internetbuilder internetbuilder mentioned this pull request Jul 5, 2023
Open
@kennedytoomey kennedytoomey mentioned this pull request Jul 5, 2023
Open
@Qdigital Qdigital mentioned this pull request Jul 5, 2023
Open
@kennedytoomey kennedytoomey mentioned this pull request Jul 5, 2023
Open
@tglt-9794 tglt-9794 mentioned this pull request Jul 6, 2023
Open
@internetbuilder internetbuilder mentioned this pull request Jul 6, 2023
Open
@jackromo888 jackromo888 mentioned this pull request Jul 6, 2023
Open
@jayjay7984 jayjay7984 mentioned this pull request Jul 6, 2023
Open
@internetbuilder internetbuilder mentioned this pull request Jul 6, 2023
Open
@Qdigital Qdigital mentioned this pull request Jul 6, 2023
Open
@kennedytoomey kennedytoomey mentioned this pull request Jul 6, 2023
Open
@Qdigital Qdigital mentioned this pull request Jul 6, 2023
Open
@jayjay7984 jayjay7984 mentioned this pull request Jul 6, 2023
Open
@Qdigital Qdigital mentioned this pull request Jul 6, 2023
Open
@jayjay7984 jayjay7984 mentioned this pull request Jul 6, 2023
Open
This was referenced Jul 6, 2023
Open
Open
@internetbuilder internetbuilder mentioned this pull request Jul 6, 2023
Open
@jackromo888 jackromo888 mentioned this pull request Jul 6, 2023
Open
@jayjay7984 jayjay7984 mentioned this pull request Jul 6, 2023
Open
@internetbuilder internetbuilder mentioned this pull request Jul 6, 2023
Open
@jackromo888 jackromo888 mentioned this pull request Jul 6, 2023
Open
@tglt-9794 tglt-9794 mentioned this pull request Jul 7, 2023
Open
@jackromo888 jackromo888 mentioned this pull request Jul 7, 2023
Open
@tglt-9794 tglt-9794 mentioned this pull request Jul 7, 2023
Open
@kennedytoomey kennedytoomey mentioned this pull request Jul 7, 2023
Open
@jayjay7984 jayjay7984 mentioned this pull request Jul 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanjhughes alanjhughes alanjhughes approved these changes

@lukmccall lukmccall Awaiting requested review from lukmccall

Assignees
No one assigned
Labels
bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[image-picker][android] Crash on new photo picker on older android devices
5 participants
@thespacemanatee @AquilesOliveiraDev @alanjhughes @brentvatne @expo-bot