[modules-core][Android] Fixed the ErrorViewGroup cannot be cast to view class exception
#23651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…view class exception
tsapeta
approved these changes
Jul 20, 2023
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
tsapeta
pushed a commit
that referenced
this pull request
Jul 21, 2023
…view class exception (#23651) # Why Closes #23586 # How It turns out that RN tries to set props even if the view wasn't constructed correctly and the app is in the background. We can't do much in this situation and ignore those errors. Moreover, I've improved error handling when `setPros` fails. # Test Plan - bare-expo ✅
|
Hello, This PR seems to be the last stage of that issue. Thank you in advance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes #23586
How
It turns out that RN tries to set props even if the view wasn't constructed correctly and the app is in the background. We can't do much in this situation and ignore those errors.
Moreover, I've improved error handling when
setProsfails.Test Plan